Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: use TS variant of class-methods-use-this #7

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

Kenneth-Sills
Copy link
Owner

Migrated from upstream PR.


By default, this does not deviate in behavior from the original rule. It does, however, provide users with additional configuration options to disable errors when this is not used in classes that implement interfaces or methods that explicitly override parent methods.

The configuration we provide has been left at the default, though, since those rules are arguably over-permissive in the pursuit of not requiring type information.

Closes #6 .

By default, this does not deviate in behavior from the original rule.
It does, however, provide users with additional configuration options
to disable errors when `this` is not used in classes that
implement interfaces or methods that explicitly override parent methods.

The configuration we provide has been left at the default, though,
since those rules are arguably over-permissive in the pursuit of not
requiring type information.

Closes #344.
@Kenneth-Sills Kenneth-Sills merged commit fd0f7bf into main Aug 25, 2024
@Kenneth-Sills Kenneth-Sills deleted the kesills-class-methods-use-this branch August 25, 2024 20:38
Copy link

🎉 This issue has been resolved in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using @typescript-eslint/class-methods-use-this
1 participant