Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added the maintainers list #32

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Added the maintainers list #32

merged 4 commits into from
Oct 26, 2022

Conversation

eveyonline
Copy link
Member

Thanks to the maintainers

Thanks to the maintainers
README.md Outdated
@@ -91,7 +91,7 @@ on your project.

## Limitations

This tool can be used in the following scenarii :
This tool can be used in the following scenaro :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This tool can be used in the following scenaro :
This tool can be used in the following scenario :

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding wikiperia :

However, the modern plural of the Italian word scenario is scenari.

So the fix should be scenari IMHO (I originally meant to write the plural of scenario, hence the two i's, but it looks like I wrote it wrong).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I got it wrong, from the PR I didn't get there were multiple ones!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the modern plural of the Italian word scenario is scenari. (not in english)

README.md Outdated
Comment on lines 131 to 133
[nm2107](https://github.com/nm2107)
[neghmurken](https://github.com/neghmurken)
[jaljo](https://github.com/jaljo)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔
For me you can keep only Nico in maintainers.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neghmurken , @jaljo , do you accept to be listed as maintainers ?

I'll cherry pick the commit to rebase against master once I've got your answers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'll politely decline. I have absolutely no knowledge of this project or of Rust whatsoever

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, thank you for answering :)

@jaljo, what about you ? (no obligations there :) )

Copy link
Member Author

@eveyonline eveyonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected your suggestions :)
Thank you

@eveyonline eveyonline requested a review from hlegay October 26, 2022 08:19
@eveyonline eveyonline merged commit dfbc429 into master Oct 26, 2022
@eveyonline eveyonline deleted the eveyonline-should-skip-ci branch October 26, 2022 08:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants