This repository was archived by the owner on Jul 11, 2023. It is now read-only.
fix(client) resolve FQDNs ending in dots #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locao
force-pushed
the
fix/fqdn_ending_in_dots
branch
from
d960b14 to
5c922ad
Compare
|
what are the semantics of a name ending with a dot? are they to be treated as fqdn names? so no domain searches etc? |
|
Yes, the dot at the end means the name is unambiguous, there's nothing else to search. |
kikito
approved these changes
Feb 24, 2021
Tieske
suggested changes
Feb 26, 2021
locao
force-pushed
the
fix/fqdn_ending_in_dots
branch
from
5c922ad to
2c6561c
Compare
locao
force-pushed
the
fix/fqdn_ending_in_dots
branch
from
2c6561c to
2c097f5
Compare
|
I created an alternative in #122 |
|
Superseded by #122 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.