Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

date field initializations should not rely on wrapper class #3309

Merged
merged 2 commits into from
Nov 8, 2020

Conversation

DoDSoftware
Copy link
Contributor

Fix for #3308

@pxpm
Copy link
Contributor

pxpm commented Nov 5, 2020

Hello @DoDSoftware

Thank you very much for providing the solution for this problem.

I'm looking at this now, and it seems that this problem applies also to date_range and datetime_picker.

Could you update the PR to include the fix in both those fields too, or want me to do it ?

Thanks,
Pedro

@pxpm pxpm self-assigned this Nov 5, 2020
@DoDSoftware
Copy link
Contributor Author

@pxpm Good catch! I'll update those and repush.

@pxpm pxpm added Bug Minor Bug A bug that happens only in a very niche or specific use case. Priority: SHOULD and removed Bug labels Nov 5, 2020
@DoDSoftware
Copy link
Contributor Author

@pxpm Tested and updated. Also did a search in the fields folder for ('.form-group') and didn't find any other instances beyond those.

@DoDSoftware DoDSoftware changed the title date_picker initialization should not rely on wrapper class date field initializations should not rely on wrapper class Nov 5, 2020
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@pxpm pxpm requested review from pxpm and promatik November 6, 2020 12:30
Copy link
Contributor

@pxpm pxpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DoDSoftware

@tabacitu
Copy link
Member

tabacitu commented Nov 8, 2020

This. Is freaking. AWESOME. Excellent collaboration here guys! Thanks a lot, I can merge this with so much confidence now! MERGED! 😄 It'll be available on Monday like @pxpm said.

@tabacitu tabacitu merged commit 184c6bb into Laravel-Backpack:master Nov 8, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Minor Bug A bug that happens only in a very niche or specific use case. Priority: SHOULD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants