Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

date field initializations should not rely on wrapper class #3309

Merged
merged 2 commits into from
Nov 8, 2020
Merged

date field initializations should not rely on wrapper class #3309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
373945a
date_picker initialization should not rely on wrapper class
Nov 5, 2020
317f5b5
Additional changes for other date fields with same issue
Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/resources/views/crud/fields/date_picker.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,15 @@

function bpFieldInitDatePickerElement(element) {
var $fake = element,
$field = $fake.closest('.form-group').find('input[type="hidden"]'),
$field = $fake.closest('.input-group').parent().find('input[type="hidden"]'),
$customConfig = $.extend({
format: 'dd/mm/yyyy'
}, $fake.data('bs-datepicker'));
$picker = $fake.bootstrapDP($customConfig);

var $existingVal = $field.val();

if( $existingVal.length ){
if( $existingVal && $existingVal.length ){
// Passing an ISO-8601 date string (YYYY-MM-DD) to the Date constructor results in
// varying behavior across browsers. Splitting and passing in parts of the date
// manually gives us more defined behavior.
Expand Down
4 changes: 2 additions & 2 deletions src/resources/views/crud/fields/date_range.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ function formatDate($entry, $dateFieldName)
<script>
function bpFieldInitDateRangeElement(element) {
var $visibleInput = element;
var $startInput = $visibleInput.closest('.form-group').find('.datepicker-range-start');
var $endInput = $visibleInput.closest('.form-group').find('.datepicker-range-end');
var $startInput = $visibleInput.closest('.input-group').parent().find('.datepicker-range-start');
var $endInput = $visibleInput.closest('.input-group').parent().find('.datepicker-range-end');

var $configuration = $visibleInput.data('bs-daterangepicker');
// set the startDate and endDate to the defaults
Expand Down
2 changes: 1 addition & 1 deletion src/resources/views/crud/fields/datetime_picker.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@

function bpFieldInitDateTimePickerElement(element) {
var $fake = element,
$field = $fake.closest('.form-group').find('input[type="hidden"]'),
$field = $fake.closest('.input-group').parent().find('input[type="hidden"]'),
$customConfig = $.extend({
format: 'DD/MM/YYYY HH:mm',
defaultDate: $field.val(),
Expand Down