Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: implement user tags • part 1 #196

Merged
merged 5 commits into from
Dec 29, 2024
Merged

feat: implement user tags • part 1 #196

merged 5 commits into from
Dec 29, 2024

Conversation

AkesiSeli
Copy link
Contributor

@AkesiSeli AkesiSeli commented Dec 29, 2024

Technical details

This PR contains the persistence and domain layers needed to implement user tagging as tracked by #195.

Additional notes

Future PRs will contain the UI and the business logic needed to manage tags and membership.

@AkesiSeli AkesiSeli added the enhancement New feature or request label Dec 29, 2024
@AkesiSeli AkesiSeli self-assigned this Dec 29, 2024
@AkesiSeli AkesiSeli linked an issue Dec 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 95.08197% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...persistence/repository/DefaultUserTagRepository.kt 94.64% 0 Missing and 3 partials ⚠️
Flag Coverage Δ
unittests 56.43% <95.08%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rlemmy/core/persistence/data/UserTagMemberModel.kt 100.00% <100.00%> (ø)
...ersistence/repository/DefaultSettingsRepository.kt 71.63% <ø> (ø)
...persistence/repository/DefaultUserTagRepository.kt 94.64% <94.64%> (ø)

@AkesiSeli AkesiSeli changed the title feat: implement user tags feat: implement user tags • 1 Dec 29, 2024
@AkesiSeli AkesiSeli marked this pull request as ready for review December 29, 2024 13:16
@AkesiSeli AkesiSeli changed the title feat: implement user tags • 1 feat: implement user tags • part 1 Dec 29, 2024
@AkesiSeli AkesiSeli merged commit 1e6ce07 into master Dec 29, 2024
3 checks passed
@AkesiSeli AkesiSeli deleted the feat-user-tags branch December 29, 2024 13:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant