Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix region masking for TS diagrams #954

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Fix region masking for TS diagrams #954

merged 1 commit into from
Apr 8, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 8, 2023

With the latest xarray (2023.3.0), we can't use chunked (dask) data arrays as boolean masks anymore.

@xylar xylar added the bug label Apr 8, 2023
@xylar xylar self-assigned this Apr 8, 2023
@xylar xylar mentioned this pull request Apr 8, 2023
Merged
@xylar
Copy link
Collaborator Author

xylar commented Apr 8, 2023

Testing

I tested this, along with #953 and #955 in:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/chrysalis/fix_moc_nans_in_z/

Most tests passed. The no_ncclimo test appears to need a fix to MPAS-Tools related to fill values.

@xylar xylar mentioned this pull request Apr 8, 2023
Merged
@xylar
Fix region masking for TS diagrams
b1ec4b0 
With the latest xarray (2023.3.0), we can't use chunked (dask)
data arrays as boolean masks anymore.
@xylar xylar force-pushed the fix_dask_masking_in_ts_diagrams branch from 6f79198 to b1ec4b0 Compare April 8, 2023 14:49
@xylar xylar merged commit f6057f0 into MPAS-Dev:develop Apr 8, 2023
@xylar xylar deleted the fix_dask_masking_in_ts_diagrams branch April 8, 2023 15:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar