Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix NaNs in MOC postprocessing #955

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Fix NaNs in MOC postprocessing #955

merged 1 commit into from
Apr 8, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 8, 2023 •
edited
Loading

We need to use nansum in some places where a normal sum used to work because of the new masking feature in MPAS-Ocean.

closes #947

@xylar xylar added the bug label Apr 8, 2023
@xylar xylar self-assigned this Apr 8, 2023
@xylar
Copy link
Collaborator Author

xylar commented Apr 8, 2023

Testing

I tested this, along with #953 and #954 in:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/chrysalis/fix_moc_nans_in_z/

Most tests passed. The no_ncclimo test appears to need a fix to MPAS-Tools related to fill values.

This was referenced Apr 8, 2023
Merged
Merged
@xylar xylar merged commit 308599c into MPAS-Dev:develop Apr 8, 2023
@xylar xylar deleted the fix_moc_nans_in_z branch April 8, 2023 15:22
@xylar xylar mentioned this pull request Apr 9, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MOC for SORRM run on Chicoma giving error
1 participant
@xylar