add brtemp and cldmask under diag var_struct of `src/core_atmosphere/Registry.xml
#1232
Conversation
|
@jim-p-w Can you update the PR description and also the commit message to explain why we need to add variables to the MPAS-A Registry that are not used anywhere in the MPAS-A model? Also, it would be worth noting that these variables should have no impact on memory usage for stand-alone MPAS-A applications due to the package that's attached to the variables. As it is, the description is probably not useful for MPAS-A developers, and I think an important function of PR descriptions is to convince maintainers of a repository that code changes should be accepted into the repository. |
jim-p-w
force-pushed
the
atmosphere/add_brtemp_cldmask
branch
from
43d4bf2
to
8cc229d
Compare
|
@mgduda The PR description and commit message have been updated. |
|
@jim-p-w The commit message begins with "This merge adds brtemp and cldmask under diag var_struct of src/core_atmosphere/Registry.xml (#43)". The commit isn't a merge, and #43 isn't anything related to these changes in the MPAS-Dev/MPAS-Model repository. Also, note that we try to keep the one-line summary of commit messages to 80 characters or less. I would also suggest removing the bit about madwrf and SACA from the PR description, removing the "DESCRIPTION OF CHANGES:" and "LIST OF MODIFIED FILES:" lines, and also removing the part about cherry-picking. |
|
How about For the PR message use the same verbiage, but change |
I think it would be nice if there were a way to include "MPAS-JEDI" in the one-line summary, which we'd see with, e.g., Also, perhaps rather than "used by MPAS-JEDI", would it be fair to say "required by MPAS-JEDI"? |
…S-JEDI These fields are required by MPAS-JEDI and are associated with the `jedi_da` package, which is active only if `config_jedi_da = true`. Without setting `config_jedi_da = true` this commit should have no impact on memory usage for stand-alone MPAS-A applications.
jim-p-w
force-pushed
the
atmosphere/add_brtemp_cldmask
branch
from
8cc229d
to
9d312db
Compare
|
@mgduda I've done another update to the PR and commit verbiage . |
This merge addresses several issues in the MPAS-Atmosphere model and in the MPAS infrastructure. Specific changes in this merge include: * Fix to a portability issue in the MPAS registry 'parse' tool, which caused files in the src/core_<CORE>/inc directory to not be generated correctly at build time on some systems (PR #1229). * Addition of two fields, brtemp and cldmask, that are needed by MPAS-JEDI. Although not needed by stand-alone MPAS-Atmosphere, these fields are associated with the 'jedi_da' package and therefore have no effect when MPAS-Atmosphere is run without setting config_jedi_da = true (PR #1232). * Removal of a redundant query of the nCellsSolve dimension in the physics_run_init routine. The extra query had no impact on results, and its removal can be considered clean-up (PR #1236).
Add brtemp and cldmask fields to atmosphere Registry.xml file for MPAS-JEDI.
These fields are required by MPAS-JEDI and are associated with the
jedi_dapackage,which is active only if
config_jedi_da = true.Without setting
config_jedi_da = truethis PR should have no impact onmemory usage for stand-alone MPAS-A applications.