Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix dialog tag specs #23078

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

GilbertCherrie
Copy link
Member

Fix dialog tag specs as a follow up to this pr: ManageIQ/manageiq-automation_engine#545

@GilbertCherrie GilbertCherrie requested a review from Fryguy as a code owner July 3, 2024 20:49
@GilbertCherrie
Copy link
Member Author

@miq-bot assign @agrare
@miq-bot assign @Fryguy
@miq-bot add-label test

@miq-bot miq-bot assigned agrare and Fryguy and unassigned agrare Jul 3, 2024
@miq-bot miq-bot added the test label Jul 3, 2024
.byebug_history Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend adding .byebug_history to your global gitignore ~/.gitignore so these don't get accidentally committed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't notice those, should be fixed now.

@GilbertCherrie GilbertCherrie force-pushed the fix_dialog_tag_specs branch 2 times, most recently from fe3a3c3 to a6abff8 Compare July 3, 2024 21:06
@GilbertCherrie GilbertCherrie force-pushed the fix_dialog_tag_specs branch from a6abff8 to 04d71a9 Compare July 3, 2024 21:06
@miq-bot
Copy link
Member

miq-bot commented Jul 3, 2024

Checked commit GilbertCherrie@04d71a9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@agrare agrare assigned agrare and unassigned Fryguy Jul 4, 2024
@agrare agrare merged commit f133c62 into ManageIQ:master Jul 4, 2024
8 checks passed
@agrare
Copy link
Member

agrare commented Jul 4, 2024

Marking radjabov/yes ManageIQ/manageiq-automation_engine#545 is backported already

@GilbertCherrie GilbertCherrie deleted the fix_dialog_tag_specs branch July 5, 2024 13:41
@Fryguy
Copy link
Member

Fryguy commented Jul 9, 2024

Backported to radjabov in commit bfdc01d.

commit bfdc01d13b37f0b3bd638bb01f2f9e129ad92c90
Author: Adam Grare <adam@grare.com>
Date:   Thu Jul 4 10:29:42 2024 -0400

    Merge pull request #23078 from GilbertCherrie/fix_dialog_tag_specs
    
    Fix dialog tag specs
    
    (cherry picked from commit f133c62f5ddc5e1010ce89ecee76d88402aae218)

Fryguy pushed a commit that referenced this pull request Jul 9, 2024
Fix dialog tag specs

(cherry picked from commit f133c62)
Fryguy added a commit that referenced this pull request Sep 6, 2024
@Fryguy
Copy link
Member

Fryguy commented Sep 6, 2024

Reverted the backport to radjabov via e30ab9d

Fryguy added a commit that referenced this pull request Nov 4, 2024
…specs"

This reverts commit f133c62, reversing
changes made to 77e5f7a.
@Fryguy
Copy link
Member

Fryguy commented Nov 4, 2024

Reverted via 1b2f4e7

commit 1b2f4e73ee2e43dedccecd0105e4a850fc1a6655 (HEAD -> master, upstream/master, upstream/HEAD)
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Nov 4 14:47:29 2024 -0500

    Revert "Merge pull request #23078 from GilbertCherrie/fix_dialog_tag_specs"

    This reverts commit f133c62f5ddc5e1010ce89ecee76d88402aae218, reversing
    changes made to 77e5f7a66cdecdae55e5b816c38a3e21fe6efc2a.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants