Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix dialog tag specs #23155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GilbertCherrie
Copy link
Member

Depends on: ManageIQ/manageiq-automation_engine#555

Fixes specs after automation engine code is changed for the tag field in this pr: ManageIQ/manageiq-automation_engine#555.

Reverting the tests back to before this pr: #23078

@GilbertCherrie
Copy link
Member Author

@miq-bot assign @jrafanie
@miq-bot add-label bug

@GilbertCherrie
Copy link
Member Author

@miq-bot add-reviewer @jrafanie

@GilbertCherrie
Copy link
Member Author

@miq-bot cross-repo-test ManageIQ/manageiq-automation_engine#555

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
@GilbertCherrie
Copy link
Member Author

GilbertCherrie commented Aug 21, 2024

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
@GilbertCherrie GilbertCherrie force-pushed the fix_dialog_tag_specs branch 2 times, most recently from f7f5bc1 to ee5e5b6 Compare August 21, 2024 19:07
@GilbertCherrie
Copy link
Member Author

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 21, 2024
@GilbertCherrie
Copy link
Member Author

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 26, 2024
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 26, 2024
@GilbertCherrie GilbertCherrie force-pushed the fix_dialog_tag_specs branch 4 times, most recently from 9e8df23 to 64520e3 Compare August 26, 2024 20:19
@GilbertCherrie
Copy link
Member Author

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 26, 2024
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 26, 2024
@GilbertCherrie GilbertCherrie force-pushed the fix_dialog_tag_specs branch 5 times, most recently from 15b03f3 to 4b50a80 Compare September 5, 2024 17:55
@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2024

Checked commit GilbertCherrie@be8000f with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 1 offense detected

app/models/service_orchestration/provision_tagging.rb

@miq-bot
Copy link
Member

miq-bot commented Nov 4, 2024

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Feb 10, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants