-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(keyring-api)!: add scopes
field to KeyringAccount
#5066
Draft
ccharly
wants to merge
2
commits into
main
Choose a base branch
from
feat/keyring-account-scopes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@metamaskbot publish-preview |
ccharly
changed the title
chore: wip
feat(keyring-api)!: add Dec 13, 2024
scopes
field to KeyringAccount
ccharly
force-pushed
the
feat/keyring-account-scopes
branch
from
December 13, 2024 10:53
0a46981
to
28a9753
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
ccharly
force-pushed
the
feat/keyring-account-scopes
branch
from
December 13, 2024 11:06
28a9753
to
2a41698
Compare
ccharly
force-pushed
the
feat/keyring-account-scopes
branch
from
December 13, 2024 11:08
2a41698
to
808b388
Compare
8 tasks
// TODO: Either fix this lint violation or explain why it's necessary to ignore. | ||
// eslint-disable-next-line @typescript-eslint/restrict-template-expressions | ||
[`${BtcAccountType.P2wpkh}`]: [...Object.values(BtcMethod)], | ||
[`${BtcAccountType.P2wpkh}`]: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we take the opportunity to test that we support all account types for Bitcoin in this PR?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Testing the new
scopes
field forKeyringAccount
References
scopes
field toKeyringAccount
accounts#101scopes
field toKeyringAccount
metamask-extension#29195Changelog
TODO
Checklist