Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(keyring-api)!: add scopes field to KeyringAccount #5066

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Dec 13, 2024

Explanation

Testing the new scopes field for KeyringAccount

References

Changelog

TODO

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly
Copy link
Contributor Author

ccharly commented Dec 13, 2024

@metamaskbot publish-preview

@ccharly ccharly changed the title chore: wip feat(keyring-api)!: add scopes field to KeyringAccount Dec 13, 2024
@ccharly ccharly force-pushed the feat/keyring-account-scopes branch from 0a46981 to 28a9753 Compare December 13, 2024 10:53
@ccharly
Copy link
Contributor Author

ccharly commented Dec 13, 2024

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "20.0.2-preview-28a9753",
  "@metamask-previews/address-book-controller": "6.0.2-preview-28a9753",
  "@metamask-previews/announcement-controller": "7.0.2-preview-28a9753",
  "@metamask-previews/approval-controller": "7.1.1-preview-28a9753",
  "@metamask-previews/assets-controllers": "45.1.2-preview-28a9753",
  "@metamask-previews/base-controller": "7.0.2-preview-28a9753",
  "@metamask-previews/build-utils": "3.0.2-preview-28a9753",
  "@metamask-previews/chain-controller": "0.2.2-preview-28a9753",
  "@metamask-previews/composable-controller": "10.0.0-preview-28a9753",
  "@metamask-previews/controller-utils": "11.4.4-preview-28a9753",
  "@metamask-previews/ens-controller": "15.0.1-preview-28a9753",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-28a9753",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-28a9753",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-28a9753",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-28a9753",
  "@metamask-previews/keyring-controller": "19.0.2-preview-28a9753",
  "@metamask-previews/logging-controller": "6.0.3-preview-28a9753",
  "@metamask-previews/message-manager": "11.0.3-preview-28a9753",
  "@metamask-previews/multichain": "1.1.2-preview-28a9753",
  "@metamask-previews/name-controller": "8.0.2-preview-28a9753",
  "@metamask-previews/network-controller": "22.1.1-preview-28a9753",
  "@metamask-previews/notification-services-controller": "0.15.0-preview-28a9753",
  "@metamask-previews/permission-controller": "11.0.4-preview-28a9753",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-28a9753",
  "@metamask-previews/phishing-controller": "12.3.1-preview-28a9753",
  "@metamask-previews/polling-controller": "12.0.2-preview-28a9753",
  "@metamask-previews/preferences-controller": "15.0.1-preview-28a9753",
  "@metamask-previews/profile-sync-controller": "3.1.1-preview-28a9753",
  "@metamask-previews/queued-request-controller": "8.0.2-preview-28a9753",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-28a9753",
  "@metamask-previews/remote-feature-flag-controller": "1.2.0-preview-28a9753",
  "@metamask-previews/selected-network-controller": "20.0.2-preview-28a9753",
  "@metamask-previews/signature-controller": "23.1.0-preview-28a9753",
  "@metamask-previews/transaction-controller": "42.0.0-preview-28a9753",
  "@metamask-previews/user-operation-controller": "21.0.0-preview-28a9753"
}

@ccharly ccharly force-pushed the feat/keyring-account-scopes branch from 28a9753 to 2a41698 Compare December 13, 2024 11:06
// TODO: Either fix this lint violation or explain why it's necessary to ignore.
// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
[`${BtcAccountType.P2wpkh}`]: [...Object.values(BtcMethod)],
[`${BtcAccountType.P2wpkh}`]: {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we take the opportunity to test that we support all account types for Bitcoin in this PR?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants