Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mouse disease fixes, and cooking purges disease #3152

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

PotatoTomahto
Copy link
Contributor

@PotatoTomahto PotatoTomahto commented Aug 27, 2024

About The Pull Request

Mouse-related:

  • Diseased mouse will transfer all their diseases into their blood reagent. All of their disease spread is downgraded to blood only when this happens.
  • Removes unused mouse code

Other:

  • Cooking with either crafting or soup purges all disease from reagents.
  • get_spread_string() will now return spread_text if defined. Used for diseases that have special spread text
  • Fixed some runtimes and span

Why It's Good For The Game

Firstly, diseases weren't being transferred from the alive mouse to its dead counterpart, so that's a bug fix. Secondly, we have had too many rounds where entire stations have been infected by mouse diseases. Downgrading spread of disease from dead mice should limit "griefing" by mouse enjoyers. Cooking removing diseases also provides a way to safely eat mice.

Changelog

🆑
add: Cooking removes diseases from all reagents.
fix: Mice properly transfer their disease to their dead carcass.
/:cl:

@PotatoTomahto PotatoTomahto reopened this Aug 28, 2024
@PotatoTomahto PotatoTomahto reopened this Aug 29, 2024
@PotatoTomahto PotatoTomahto changed the title Mouse disease changes, and cooking purges disease Mouse disease fixes, and cooking purges disease Aug 31, 2024
@PotatoTomahto PotatoTomahto force-pushed the mouse branch 2 times, most recently from b2232bb to 9a02425 Compare September 1, 2024 03:35
code/datums/components/crafting/crafting.dm Outdated Show resolved Hide resolved
code/datums/components/crafting/crafting.dm Outdated Show resolved Hide resolved
monkestation/code/modules/virology/machines/curer.dm Outdated Show resolved Hide resolved
PotatoTomahto and others added 3 commits September 19, 2024 21:34
Co-authored-by: Lucy <lucy@absolucy.moe>
Co-authored-by: Lucy <lucy@absolucy.moe>
Co-authored-by: Lucy <lucy@absolucy.moe>
@Absolucy Absolucy merged commit 2c230a8 into Monkestation:master Sep 20, 2024
22 checks passed
github-actions bot added a commit that referenced this pull request Sep 20, 2024
@PotatoTomahto PotatoTomahto deleted the mouse branch November 20, 2024 06:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants