Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MapObj: Implement CapBomb #304

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

GRAnimated
Copy link
Collaborator

@GRAnimated GRAnimated commented Jan 23, 2025

Used somewhere in the game...
It initializes a test layout & parts but doesn't use them.


This change is Reviewable

Copy link
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, as far as I can tell, these are unused - none of the bymls in StageData contain a reference to CapBomb.

Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @GRAnimated)


data/odyssey_functions.csv line 0 at r1 (raw file):
Missing ActorFactory entry

Copy link
Collaborator Author

@GRAnimated GRAnimated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)


data/odyssey_functions.csv line at r1 (raw file):

Previously, MonsterDruide1 wrote…

Missing ActorFactory entry

Done.

Copy link
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @GRAnimated)

@MonsterDruide1 MonsterDruide1 merged commit 990b784 into MonsterDruide1:master Jan 28, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants