-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
7624 - Subcategories front-end styling for mobile #7761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mobile
- If the creep-o-meter face is relocating and we do not have a heading, can we reduce the gap above the checkbox so it is more balanced on mobile
- Subcategories scroll on mobile so it works but when I click on one, the search becomes active and my keyboard is triggered each time and the creep face gets pushed up too which makes it hard to browse products. See video:
https://user-images.githubusercontent.com/2492510/140180489-41ac3e12-0e09-42c4-b239-3f980f9ba827.mp4
Desktop (narrow viewports)
0ac178e
to
27a947d
Compare
Mobile Fixes Desktop fixes
27a947d
to
82c22f0
Compare
This PR introduces visual differences. Click here to inspect the diffs. |
This PR introduces visual differences. Click here to inspect the diffs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing
- The mobile spacing looks good now but we lost the spacing above creep-o-meter that was added for desktop previously in 7623 - Subcategories - front-end styling for desktop #7712 (review)
Hide Scrollbar?
The scrolling works now but a big scroll appears now on...
narrow viewports:
and mobile:
https://user-images.githubusercontent.com/2492510/140402658-16ef9d7f-92e8-4c36-992d-8375ec652abe.mp4
- Is it possible to hide it while keeping the side scroll functionality?
- on narrow viewports, is it possible for the subcategories to extend to the edge of the page instead of being cut off at the container?
Thanks for fixing the keyboard trigger issue on mobile, it works way better!
This PR introduces visual differences. Click here to inspect the diffs. |
This PR introduces visual differences. Click here to inspect the diffs. |
1 similar comment
This PR introduces visual differences. Click here to inspect the diffs. |
af78a4e
to
fd1e8a2
Compare
This PR introduces visual differences. Click here to inspect the diffs. |
fd1e8a2
to
092ab03
Compare
This PR introduces visual differences. Click here to inspect the diffs. |
092ab03
to
eab6414
Compare
Fixed creepyface fix subcategories should take full width oops done
eab6414
to
cbbe3b8
Compare
This PR introduces visual differences. Click here to inspect the diffs. |
1 similar comment
This PR introduces visual differences. Click here to inspect the diffs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the cut off issue and hiding the scrollbar! 👍
I'll file a separate QA to be able to drag to scroll the subcategories to improve usability
I filed the QA drag to scroll issue here: #7787 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Simon! Thanks for tagging me on this:
I took a look at the code and everything looks good to me, I did find one minor thing however I am not sure if it is by design:
At the medium breakpoint the subcategories seem to get unaligned with the large category at the top:
If this is to be expected, please let me know and I will approve the changes, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Simon! Thanks for answering my questions, approved!
Includes front end stylings for mobile
Closes #7624
Related PRs/issues #7746
You do need to create subcategories on the test site via the admin account in order to test