-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
E02 admin models #279
base: ceres-connection
Are you sure you want to change the base?
E02 admin models #279
Conversation
eswarsaladi
commented
Feb 2, 2024
- Added Babel and Webpack setup
- Seperated couple of functions to seperate folders
- Seperated collections, models and views to seperate folders
- Fixed issue with babel and webpack setup messing up the functionality
Co-authored-by: gendev1 <hello@generalist.dev>
…-plugin into 262-refactor-selectitem
assets/js/admin.js
Outdated
if (this.current_tab == 6) { | ||
titles = this.validTime(); | ||
titles = titles.join('\n'); | ||
alert('The following item(s) are outside the specified date range or do not have date values: \n' + titles); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love seeing informative messages being added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a lot of the Ceres library was removed or changed here? We should talk here about that. My first instinct is that we'll need those files later, but want to hear your reasoning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While merging with ceres-connection, I ended up pulling latest code from ceres library. that is mistake should I be reverting to older code for ceres library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remind me of the role React plays here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh! While I was going through the whole code, I realized we were storing the state mostly in DOM, I wanted to test out if I can rewrite the modal functionality using react js, once I am done with refactoring the present code. It does not do anything for now, will remove the dependency once I test out my little experiement.