Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

E02 admin models #279

Open
wants to merge 47 commits into
base: ceres-connection
Choose a base branch
from
Open

E02 admin models #279

wants to merge 47 commits into from

Conversation

eswarsaladi
Copy link
Collaborator

  • Added Babel and Webpack setup
  • Seperated couple of functions to seperate folders
  • Seperated collections, models and views to seperate folders
  • Fixed issue with babel and webpack setup messing up the functionality

patrickmj and others added 30 commits April 20, 2023 15:45
Co-authored-by: gendev1 <hello@generalist.dev>
@eswarsaladi eswarsaladi requested a review from patrickmj February 2, 2024 19:58
if (this.current_tab == 6) {
titles = this.validTime();
titles = titles.join('\n');
alert('The following item(s) are outside the specified date range or do not have date values: \n' + titles);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love seeing informative messages being added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of the Ceres library was removed or changed here? We should talk here about that. My first instinct is that we'll need those files later, but want to hear your reasoning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While merging with ceres-connection, I ended up pulling latest code from ceres library. that is mistake should I be reverting to older code for ceres library?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remind me of the role React plays here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh! While I was going through the whole code, I realized we were storing the state mostly in DOM, I wanted to test out if I can rewrite the modal functionality using react js, once I am done with refactoring the present code. It does not do anything for now, will remove the dependency once I test out my little experiement.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants