Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add stop button to audio menu entries #1108

Closed
MrTantum opened this issue Mar 9, 2019 · 1 comment · Fixed by #1380
Closed

Add stop button to audio menu entries #1108

MrTantum opened this issue Mar 9, 2019 · 1 comment · Fixed by #1380
Assignees
@mayjak
Labels
enhancement
Milestone
2.5

Comments

@MrTantum
Copy link

MrTantum commented Mar 9, 2019 •
edited
Loading

Description of Problem or Question

Testing sounds in editor is currently not really possible because there is no way to stop an audio sample after you have started it.

Would it be possible to show a stop button for audio files which have been started and make the file stop after clicking on it?

grafik

Valkyrie Version

2.2
@BenRQ
Copy link
Collaborator

BenRQ commented Mar 27, 2019

Seeing the number of likes, I will move this one to high priority on 2.4 :)

@NPBruce NPBruce added this to the 2.5 milestone Aug 8, 2019
@NPBruce NPBruce mentioned this issue Oct 27, 2019
Closed
@mayjak mayjak self-assigned this Oct 29, 2020
@mayjak mayjak mentioned this issue Oct 31, 2020
Merged
mayjak added a commit that referenced this issue Nov 8, 2020
@mayjak
#1108 Editor audio selection improvements (#1380)
8097076 
- play button now correctly stops the previously playing sound
- if audio key or file does not exist a stop button is shown instead of the play button
@mayjak mayjak mentioned this issue Nov 25, 2020
Merged
mayjak pushed a commit that referenced this issue Nov 25, 2020
@estarriol
#1108 Editor audio selection improvements (#1380)
8af4993 
- play button now correctly stops the previously playing sound
- if audio key or file does not exist a stop button is shown instead of the play button
@mayjak mayjak closed this as completed Nov 25, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mayjak mayjak

Labels
enhancement
Projects
None yet
Milestone
2.5
Development

Successfully merging a pull request may close this issue.

#1108 Editor audio selection improvements mayjak/valkyrie
5 participants
@redwolf2 @mayjak @NPBruce @MrTantum @BenRQ