Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] Migo and Serpent Person Issues #1326

Closed
strategywizard opened this issue Jul 7, 2020 · 4 comments · Fixed by #1378
Closed

[Bug] Migo and Serpent Person Issues #1326

strategywizard opened this issue Jul 7, 2020 · 4 comments · Fixed by #1378
Assignees
Labels

Comments

@strategywizard
Copy link

A review left on my scenario, Search for a Friend, mentioned that the Migo monster had no Evade or Horror effects. I did a quick run through and found that this was actually the case.

I also noticed that the Serpent Person monster won't allow me to attack with a Spell when I run through a scenario that I'm working on.

Valkyrie Version 2.4.09

  • Windows 10
@redwolf2
Copy link
Collaborator

redwolf2 commented Jul 7, 2020

I can confirm, that "Evade" and "Horror Check" on the MiGo doesn't work for me eigther.

I can also confirm the Serpent Person bug:

grafik

The Reason might be, because Serpent Person has some special attacks.

ATTACK_BLADED_VS_SNAKE_PERSON_08
ATTACK_FIREARM_VS_SNAKE_PERSON_11
ATTACK_FIREARM_VS_SNAKE_PERSON_12
ATTACK_HEAVY_VS_SNAKE_PERSON_10
ATTACK_HEAVY_VS_SNAKE_PERSON_18
ATTACK_UNARMED_VS_SNAKE_PERSON_02
ATTACK_UNARMED_VS_SNAKE_PERSON_05

But there are no special attacks for spells. The official app is using the default monster attacks as a fallback in those cases. The Serpent Person seems to be the only monster that falls short regarding custom monster texts.

@mayjak mayjak self-assigned this Oct 29, 2020
@antontimmermans
Copy link
Collaborator

this ticket has overlap with #1157

@mayjak
Copy link
Collaborator

mayjak commented Oct 31, 2020

This is actually interesting. As it is now we only support a few attacks against the snake person. What the FFG app does is it treats the snake person as a humanoid, except for the attacks that mention legs in the description, which are obviously replaced by a snake tail in the descriptions.

I think the easiest fix for now is to add the attack mappings to the .ini file. That's because it's the only case that modify another "trait" attacks. I'll have a fix today.

The migo is a bit different case I think, but I'll check that as well.

@mayjak
Copy link
Collaborator

mayjak commented Oct 31, 2020

So for the migo it seems there's a very simple string casing issue in horrors.ini and evade.ini ("Migo" instead of "MiGo"). Fix coming soon.

mayjak added a commit to mayjak/valkyrie that referenced this issue Oct 31, 2020
…in FFG app resources)

Fixed horror and evade checks for MiGo

Fixes NPBruce#1157 NPBruce#1326
mayjak added a commit that referenced this issue Nov 8, 2020
* Fixed attacks against SNAKE_PERSON (beware, it's also SERPENT_PERSON in FFG app resources)
* Fixed horror and evade checks for MiGo
* Removed ATTACK_UNARMED_VS_HUMANOID_10 and ATTACK_HEAVY_VS_HUMANOID_04 as it mentions a knee.
Fixes #1157 
Fixes #1326
@mayjak mayjak mentioned this issue Nov 25, 2020
@mayjak mayjak closed this as completed in bba3b5b Nov 25, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants