Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Extinguish Fire option in Pop-up during Mythos #1348

Closed
antontimmermans opened this issue Aug 30, 2020 · 2 comments
Closed

[Feature] Extinguish Fire option in Pop-up during Mythos #1348

antontimmermans opened this issue Aug 30, 2020 · 2 comments
Assignees

Comments

@antontimmermans
Copy link
Collaborator

Is your feature request related to a problem? Please describe.**

In the feedback on my scenarios, the comment indicates that it is not clear to new players using Valkyrie how to clear the fire. The FFG app also provides this option in the phase where the 'fire spreads'. A payer can choose the option 'fire spreads' or 'fire extinguished. Since this option s not shown in the current Valkyrie app (2.4.09), new players automatically assume that it is a scenario bug.

Describe the solution you'd like

Add the option to extinguish the fire in the message where the fire spreads text is displayed during mythos phase. (see Blue marker in the image below)
ExtinguishFire

Describe alternatives you've considered

The alternative to clear the fire is to use the current mechanism with the Set button in the current game menu (see the red marker in the attached image. The text color of that button could turn red when $fire == 1 and default white when $fire == 0. This would also alert players where to look in the interface, but I find the addition of the button more clear and intuitive since it mimics the FFG behavior better.
Optionally you could do both: Add the extinguish fire button in the event message AND color the Set button depending on the status of the $fire variable.

Additional context

Add any other context or screenshots about the feature request here.

@scrubbless scrubbless changed the title [Feature] Extinghuish Fire option in Pop-up during Mythos [Feature] Extinguish Fire option in Pop-up during Mythos Sep 3, 2020
@mayjak mayjak self-assigned this Oct 29, 2020
mayjak added a commit that referenced this issue Nov 19, 2020
@mayjak
Copy link
Collaborator

mayjak commented Nov 19, 2020

I added the 2nd button to clear the fire in mythos phase.

mayjak added a commit that referenced this issue Nov 19, 2020
mayjak added a commit that referenced this issue Nov 19, 2020
@antontimmermans
Copy link
Collaborator Author

antontimmermans commented Nov 19, 2020

Thanks for implementing this one.

That button would also need translations.

You could either re-use the translated text from the menu option to set and clear fire (bottom left of the screen). The text there says "clear fire". The valkyrie localization files will likely have the correct translation for it in all languages.
OR
The official FFG app uses the term "Fire Extinguished". Maybe you can reuse that term from FFG's localization files although I don't know how that works or if it is possible.
OR
Google translate will probably give you OK results for "Fire Extinguished". But the translation channels in Discord may give you better suggestions.

FYI: Google translated "Fire extinguished":

  • German: Feuer gelöscht
  • French: Feu éteint
  • Spanish: Fuego extinguido
  • Portuguese: Fogo extinto
  • Polish: Pożar ugaszony
  • Italian: Fuoco spento
  • Chinese: 灭火 (<- I assume that Valkyrie uses simplified Chinese, traditional Chinese would be 滅火)
  • Korean: 화재 진압
  • Russian: пожар потушен

Google translated "Fire Spreads"

  • German: Feuer breitet sich aus
  • French: le feu se propage
  • Spanish: el fuego se propaga
  • Portuguese: fogo se espalha
  • Polish: rozprzestrzenia się ogień
  • Italian: il fuoco si propaga
  • Chinese: 火势蔓延(<- I assume that Valkyrie uses simplified Chinese, traditional Chinese would be 火勢蔓延)
  • Korean: 화재 확산
  • Russian: огонь распространяется

@mayjak mayjak mentioned this issue Nov 25, 2020
@mayjak mayjak closed this as completed in 01fed4d Nov 25, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants