Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Feature] Variable selection dialog: Add {new} button always to top when sorting alphabetically #1384

Closed
Quantumrunner opened this issue Nov 8, 2020 · 0 comments
Closed

[Feature] Variable selection dialog: Add {new} button always to top when sorting alphabetically #1384

Quantumrunner opened this issue Nov 8, 2020 · 0 comments
Assignees
@mayjak

Comments

@Quantumrunner
Copy link
Collaborator

Is your feature request related to a problem? Please describe.**

In the Valkyrie editor the new button in the Variable selection dialog should always be the first entry in the lost when ordering alphabetically.

grafik

Currently the button sometimes appears in the middle of the list:

grafik

Describe the solution you'd like

Always add the {new} button to the top of the list (no matter of you order ascending or descending).
@mayjak mayjak self-assigned this Nov 8, 2020
@mayjak mayjak mentioned this issue Nov 11, 2020
Merged
mayjak added a commit that referenced this issue Nov 15, 2020
@mayjak
#1384 "alwaysOnTop" list items (#1389)
f42e680 
Fixes #1384

Added an "alwaysOnTop" modifier for SelectionItems.

"alwaysOnTop" items are not sorted according to standard sorting but are always placed alphabetically on top instead.

Works with all selection item and selection trait item menus
@mayjak mayjak mentioned this issue Nov 25, 2020
Merged
@mayjak mayjak closed this as completed in 56c9ee0 Nov 25, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mayjak mayjak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mayjak @Quantumrunner