Fix #8066 - Coil:Cooling:DX:CurveFit:OperatingMode: Nominal Evaporative Condenser Pump Power is marked autosizabled, but not autosized, and other autosized missing units #8247

jmarrec · 2020-09-02T13:30:24Z

Pull request overview

Fixes Coil:Cooling:DX:CurveFit:OperatingMode: Nominal Evaporative Condenser Pump Power is marked autosizabled, but not autosized #8066
Coil:Cooling:DX:CurveFit:OperatingMode: Nominal Evaporative Condenser Pump Power is marked autosizabled, but not autosized, and other autosized missing units

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

…adation isn't implemented

… CoilCoolingDXCurveFitOperatingMode

…s are properly registered Note: I made CoilCoolingDXFixture inherit SQLiteFixture instead of EnergyPlusFixture

…XCurveFitOperatingMode

jmarrec · 2020-09-02T13:31:17Z

src/EnergyPlus/Coils/CoilCoolingDXCurveFitOperatingMode.cc

@@ -158,7 +160,7 @@ void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
    bool PrintFlag = true;

    int SizingMethod = DataHVACGlobals::CoolingAirflowSizing;
-    std::string SizingString = "Rated Evaporator Air Flow Rate";
+    std::string SizingString = "Rated Evaporator Air Flow Rate [m3/s]";


jmarrec · 2020-09-02T13:31:23Z

src/EnergyPlus/Coils/CoilCoolingDXCurveFitOperatingMode.cc

@@ -168,7 +170,7 @@ void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
            DataEnvironment::StdBaroPress, ratedInletAirTemp, ratedInletAirHumRat, RoutineName);

    SizingMethod = DataHVACGlobals::CoolingCapacitySizing;
-    SizingString = "Rated Gross Total Cooling Capacity";
+    SizingString = "Rated Gross Total Cooling Capacity [W]";


jmarrec · 2020-09-02T13:31:28Z

src/EnergyPlus/Coils/CoilCoolingDXCurveFitOperatingMode.cc

@@ -178,11 +180,23 @@ void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
    // Auto size condenser air flow to Total Capacity * 0.000114 m3/s/w (850 cfm/ton)
    DataSizing::DataConstantUsedForSizing = this->ratedGrossTotalCap;
    DataSizing::DataFractionUsedForSizing = 0.000114;
-    SizingString = "Rated Condenser Air Flow Rate";
+    SizingString = "Rated Condenser Air Flow Rate [m3/s]";


jmarrec · 2020-09-02T13:31:44Z

src/EnergyPlus/Coils/CoilCoolingDXCurveFitOperatingMode.cc

+
+    if (this->condenserType != AIRCOOLED) {
+        // Auto size Nominal Evaporative Condenser Pump Power to Total Capacity * 0.004266 w/w (15 W/ton)
+        SizingMethod = DataHVACGlobals::AutoCalculateSizing;
+        DataSizing::DataConstantUsedForSizing = this->ratedGrossTotalCap;
+        DataSizing::DataFractionUsedForSizing = 0.004266;
+        SizingString = "Nominal Evaporative Condenser Pump Power [W]";
+        TempSize = this->original_input_specs.nominal_evap_condenser_pump_power;
+        ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
+        this->nominalEvaporativePumpPower = TempSize;
+    }
+


Autosize per IO ref at 15 W/ton.

OK, so this is just using autocalculate, makes sense. Per @rraustad comment, once they are merged together, this code change will no longer compile. It will just require altering this code to use an AutocalculateSizer class instance instead.

jmarrec · 2020-09-02T13:32:25Z

tst/EnergyPlus/unit/Coils/CoilCoolingDXCurveFitOperatingMode.unit.cc

+    EXPECT_EQ(ratedEvapAirFlowRate, thisMode.ratedEvapAirFlowRate);
+    Real64 ratedGrossTotalCap = 18827.616766698276;
+    EXPECT_EQ(ratedGrossTotalCap, thisMode.ratedGrossTotalCap);
+    // Total Capacity * 0.000114 m3/s/w (850 cfm/ton)
+    Real64 ratedCondAirFlowRate = 0.000114 * ratedGrossTotalCap;
+    EXPECT_EQ(ratedCondAirFlowRate, thisMode.ratedCondAirFlowRate);
+    // Total Capacity * 0.004266 w/w (15 W/ton)
+    Real64 nominalEvaporativePumpPower = 0.004266 * ratedGrossTotalCap;
+    EXPECT_EQ(nominalEvaporativePumpPower, thisMode.nominalEvaporativePumpPower);


Test that autosizing worked.

jmarrec · 2020-09-02T13:32:50Z

tst/EnergyPlus/unit/Coils/CoilCoolingDXCurveFitOperatingMode.unit.cc

+    std::vector<TestQuery> testQueries({
+        TestQuery("Design Size Rated Evaporator Air Flow Rate", "m3/s", ratedEvapAirFlowRate),
+        TestQuery("Design Size Rated Gross Total Cooling Capacity", "W", ratedGrossTotalCap),
+        TestQuery("Design Size Rated Condenser Air Flow Rate", "m3/s", ratedCondAirFlowRate),
+        TestQuery("Design Size Nominal Evaporative Condenser Pump Power", "W", nominalEvaporativePumpPower),
+    });
+
+    for (auto &testQuery : testQueries) {
+
+        std::string query("SELECT Value From ComponentSizes"
+                          "  WHERE CompType = '" +
+                          compType +
+                          "'"
+                          "  AND CompName = '" +
+                          compName +
+                          "'"
+                          "  AND Description = '" +
+                          testQuery.description + "'" + "  AND Units = '" + testQuery.units + "'");
+
+        // execAndReturnFirstDouble returns -10000.0 if not found
+        Real64 return_val = SQLiteFixture::execAndReturnFirstDouble(query);
+
+        if (return_val < 0) {
+            EXPECT_TRUE(false) << "Query returned nothing for " << testQuery.displayString;
+        } else {
+            EXPECT_NEAR(testQuery.expectedValue, return_val, 0.01) << "Failed for " << testQuery.displayString;
+        }
+    }


Test the SQL Output, ensure that we have the right units etc.

rraustad · 2020-09-02T14:02:57Z

PR #8070 will need to incorporate these changes. In that branch, RequestSizing has been removed.

…eratingMode_Sizing

Myoldmopar

This looks great to me. I'm testing it locally.

Myoldmopar · 2020-09-16T19:08:00Z

src/EnergyPlus/Coils/CoilCoolingDXCurveFitOperatingMode.cc

+
+    if (this->condenserType != AIRCOOLED) {
+        // Auto size Nominal Evaporative Condenser Pump Power to Total Capacity * 0.004266 w/w (15 W/ton)
+        SizingMethod = DataHVACGlobals::AutoCalculateSizing;
+        DataSizing::DataConstantUsedForSizing = this->ratedGrossTotalCap;
+        DataSizing::DataFractionUsedForSizing = 0.004266;
+        SizingString = "Nominal Evaporative Condenser Pump Power [W]";
+        TempSize = this->original_input_specs.nominal_evap_condenser_pump_power;
+        ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
+        this->nominalEvaporativePumpPower = TempSize;
+    }
+


OK, so this is just using autocalculate, makes sense. Per @rraustad comment, once they are merged together, this code change will no longer compile. It will just require altering this code to use an AutocalculateSizer class instance instead.

Myoldmopar · 2020-09-16T19:09:55Z

tst/EnergyPlus/unit/Coils/CoilCoolingDXFixture.hh

 public:
 protected:
  void SetUp() override {
-    EnergyPlus::EnergyPlusFixture::SetUp(); // Sets up the base fixture first.
+    EnergyPlus::SQLiteFixture::SetUp(); // Sets up the base fixture first.


Gotcha, just made this inherit the sqlite fixture so that you can test the sql output.

…eratingMode_Sizing

Myoldmopar · 2020-09-16T21:26:07Z

No build warnings on CI, and the diffs consist of the unit string. Nice. Building locally revealed a required code change; I'll push that up once I test a little more.

Myoldmopar · 2020-09-16T21:49:41Z

OK, I tested this locally a bit. I am able to see the units showing up in the sizing reports no problem. I wasn't able to easily confirm the fix because our files that use this object are not evaporative condensers, and although the defect file is listed as added in the defect itself, I did not find a file uploaded or in dev support. Anyway, the unit test is great and I trust that this is working for you now. I am pushing my smol change up and am going to merge this in.

jmarrec added 5 commits September 2, 2020 15:23

Initial test for #8066

ffd487d

Some things from input_specs aren't used. Use one + TODO: Latent Degr…

08c78b7

…adation isn't implemented

#8066 - Autosize the the Nominal Evaporative Condenser Pump Power for…

acc984d

… CoilCoolingDXCurveFitOperatingMode

Extend test for #8066 to also check ComponentSizes SQL to ensure unit…

22b30cb

…s are properly registered Note: I made CoilCoolingDXFixture inherit SQLiteFixture instead of EnergyPlusFixture

Fix #8066 - Also add the proper units for the sizing for COilCoolingD…

be73663

…XCurveFitOperatingMode

jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Sep 2, 2020

jmarrec commented Sep 2, 2020

View reviewed changes

Myoldmopar added this to the EnergyPlus 9.4.0 milestone Sep 2, 2020

jmarrec added 2 commits September 3, 2020 14:17

Merge remote-tracking branch 'origin/develop' into 8066_CoilDXCurveOp…

5745a77

…eratingMode_Sizing

Undo temp debug changes to SQLiteFixture to output to disk

6f077b1

Myoldmopar approved these changes Sep 16, 2020

View reviewed changes

Myoldmopar added 2 commits September 16, 2020 14:11

Merge remote-tracking branch 'origin/develop' into 8066_CoilDXCurveOp…

d293e52

…eratingMode_Sizing

Fix state arg change

26074b4

Myoldmopar merged commit de9073b into develop Sep 16, 2020

Myoldmopar deleted the 8066_CoilDXCurveOperatingMode_Sizing branch September 16, 2020 21:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #8066 - Coil:Cooling:DX:CurveFit:OperatingMode: Nominal Evaporative Condenser Pump Power is marked autosizabled, but not autosized, and other autosized missing units #8247

Fix #8066 - Coil:Cooling:DX:CurveFit:OperatingMode: Nominal Evaporative Condenser Pump Power is marked autosizabled, but not autosized, and other autosized missing units #8247

jmarrec commented Sep 2, 2020

jmarrec Sep 2, 2020

jmarrec Sep 2, 2020

jmarrec Sep 2, 2020

jmarrec Sep 2, 2020

Myoldmopar Sep 16, 2020

jmarrec Sep 2, 2020

jmarrec Sep 2, 2020

rraustad commented Sep 2, 2020

Myoldmopar left a comment

Myoldmopar Sep 16, 2020

Myoldmopar Sep 16, 2020

Myoldmopar commented Sep 16, 2020

Myoldmopar commented Sep 16, 2020

Fix #8066 - Coil:Cooling:DX:CurveFit:OperatingMode: Nominal Evaporative Condenser Pump Power is marked autosizabled, but not autosized, and other autosized missing units #8247

Fix #8066 - Coil:Cooling:DX:CurveFit:OperatingMode: Nominal Evaporative Condenser Pump Power is marked autosizabled, but not autosized, and other autosized missing units #8247

Conversation

jmarrec commented Sep 2, 2020

Pull request overview

Pull Request Author

Reviewer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Sep 2, 2020

Myoldmopar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Myoldmopar commented Sep 16, 2020

Myoldmopar commented Sep 16, 2020