Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extra singlezone SPM humidity min created if humidifier downstream of fan #2145

Closed
asparke2 opened this issue Mar 11, 2016 · 1 comment · Fixed by #4348
Closed

Extra singlezone SPM humidity min created if humidifier downstream of fan #2145

asparke2 opened this issue Mar 11, 2016 · 1 comment · Fixed by #4348

Comments

@asparke2
Copy link
Member

If you have the configuration below, where you have a humidifier downstream of a fan, and therefore a humidity control SPM on the supply outlet node, the SPM magic creates an unnecessary clone of the humidity SPM on the upstream side of the humidifier. @KaiyuSun found this configuration in the outpatient reference building.

I think the current workarounds are either to move the humidifier upstream of the fan, or to manually specify the SPMs so the magic doesn't happen.

image

Here's the example OSM:
spm_humidity_minimum.osm.txt

@jmarrec
Copy link
Collaborator

jmarrec commented Jun 7, 2021

This happens here:

for (auto& lowerNode : lowerNodes) {
std::vector<SetpointManager> _setpointManagers = lowerNode.setpointManagers();
if (std::find_if(_setpointManagers.begin(), _setpointManagers.end(), isTemperatureControl) == _setpointManagers.end()) {
for (auto _setpointManager : _supplyOutletSetpointManagers) {
SetpointManager spmClone = _setpointManager.clone(t_model).cast<SetpointManager>();
spmClone.addToNode(lowerNode);
spmClone.setName(lowerNode.name().get() + " OS Default SPM");
}
}
}

I'm not 100% sure what's safe/recommended here. Currently it clones ALL SPMs that are on the supplyOutlet Node to add it to any node downstream of fan that does not have a temperature SPM already.

  1. Only clone the Temperature ones?
  2. Keep cloning all?

I'm leaning towards 1. https://bigladdersoftware.com/epx/docs/9-5/input-output-reference/group-setpoint-managers.html#setpointmanagersinglezonehumidityminimum

The calculated supply air humidity ratio is then used as the setpoint for the designated setpoint node. A humidifier component placed upstream of the setpoint node can then use the humidity ratio setpoint to control its moisture addition rate

@tijcolem tijcolem added this to the OpenStudio SDK 3.3.0 milestone Jun 11, 2021
kbenne added a commit that referenced this issue Jun 21, 2021
Fix #2145 - Do not create an extra singlezone SPM humidity min created if humidifier downstream of fan
# for free to join this conversation on GitHub. Already have an account? # to comment