Fix #2145 - Do not create an extra singlezone SPM humidity min created if humidifier downstream of fan

[jmarrec]

Pull request overview

Fix #2145 - Do not create an extra singlezone SPM humidity min created if humidifier downstream of fan

I took the regression test humidity_control_2.rb: https://github.com/NREL/OpenStudio-resources/blob/48ce9f5134aa94156df3a6b755e4ce767a34629a/model/simulationtests/humidity_control_2.rb#L57-L83

Simulated before and after fix. The in.idf will have three less SPMs (as expected), but the eplusout.err stays clean and there is no EUI deviation.

Pull Request Author

• EnergyPlus ForwardTranslator API Changes / Additions
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• All new and existing tests passes

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[ci-commercialbuildings]

CI Results for 0dae082:

• Ubuntu 18.04:

  • OpenStudio-3.2.1-alpha+0dae0821e2-Ubuntu-18.04.deb
  • OpenStudio-3.2.1-alpha+0dae0821e2-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.2.1-alpha+0dae0821e2-Ubuntu-20.04.deb
  • OpenStudio-3.2.1-alpha+0dae0821e2-Ubuntu-20.04.tar.gz

• Darwin:

  • OpenStudio-3.2.1-alpha+0dae0821e2-Darwin.dmg
  • OpenStudio-3.2.1-alpha+0dae0821e2-Darwin.tar.gz

• Windows:

  • OpenStudio-3.2.1-alpha+0dae0821e2-Windows.exe
  • OpenStudio-3.2.1-alpha+0dae0821e2-Windows.tar.gz

[kbenne]

This gets a prize for ratio of production code change relative to test code. The code change amounts to essentially a one liner, and then a bunch of testing. Awesome.