Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[REVIEW]Upgrade the plugin to JupyterLab 3 #114

Merged
merged 29 commits into from
Feb 10, 2021
Merged

[REVIEW]Upgrade the plugin to JupyterLab 3 #114

merged 29 commits into from
Feb 10, 2021

Conversation

yidong72
Copy link
Collaborator

No description provided.

@yidong72 yidong72 requested a review from avolkov1 December 30, 2020 18:46
@yidong72 yidong72 changed the base branch from main to develop December 30, 2020 18:47
@yidong72
Copy link
Collaborator Author

yidong72 commented Jan 5, 2021

refactor the nemo and rapids module as installable python plugins. Tested the all the notebooks for RAPIDS. Cannot test the nemo notebook yet because of the difficulty of installing nemo. All notebooks work except the bqplot failed to work. It is because bqplot is not yet updated to support jupyterlab3. Check this PR for latest status of bqplot library jupyterlab3 support.

@yidong72
Copy link
Collaborator Author

yidong72 commented Jan 12, 2021 •
edited
Loading

I extract the gquant files in a separate directory. Also, I put the notebooks, tests into the right place for the right project.

@yidong72
Copy link
Collaborator Author

I rebased this branch to the latest develop branch.

@yidong72
Copy link
Collaborator Author

I put all the dependent libraries into the install_requires argument in the setup.py file. The installation steps are simplified a lot. Also, bqplot library is working now.

avolkov1
avolkov1 suggested changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished looking over the code and testing unit tests and notebooks.

Just a few minor things. Otherwise looks great. Thanks!

@yidong72
Copy link
Collaborator Author

yidong72 commented Feb 5, 2021

done the changes. Also moved the modules/my_node.py under the rapids_plugin

avolkov1
avolkov1 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@avolkov1 avolkov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. I'll merge this.

@yidong72 yidong72 merged commit d30963e into NVIDIA:develop Feb 10, 2021
@avolkov1 avolkov1 mentioned this pull request Feb 11, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@avolkov1 avolkov1 avolkov1 approved these changes

Assignees

@avolkov1 avolkov1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yidong72 @avolkov1 @doyend