Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix tests failures in url_test.py #11017

Closed
Tracked by #11004
razajafri opened this issue Jun 8, 2024 · 1 comment · Fixed by #11194
Closed
Tracked by #11004

Fix tests failures in url_test.py #11017

razajafri opened this issue Jun 8, 2024 · 1 comment · Fixed by #11194
Assignees
@mythrocks
Labels
bug Something isn't working Spark 4.0+ Spark 4.0+ issues

Comments

@razajafri
Copy link
Collaborator 

FAILED ../../../../integration_tests/src/main/python/url_test.py::test_parse_url_query_with_key
FAILED ../../../../integration_tests/src/main/python/url_test.py::test_parse_url_query_with_key_column
FAILED ../../../../integration_tests/src/main/python/url_test.py::test_parse_url_supported
FAILED ../../../../integration_tests/src/main/python/url_test.py::test_parse_url_with_key
@razajafri razajafri added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jun 8, 2024
@razajafri razajafri mentioned this issue Jun 8, 2024
Open
@razajafri razajafri added the Spark 4.0+ Spark 4.0+ issues label Jun 8, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jun 11, 2024
@mythrocks
Copy link
Collaborator

All these tests pass when ANSI mode is disabled.

@mythrocks mythrocks self-assigned this Jun 13, 2024
@mythrocks mythrocks mentioned this issue Jul 15, 2024
Open
mythrocks added a commit to mythrocks/spark-rapids that referenced this issue Jul 15, 2024
@mythrocks
Fix ANSI mode test failures in url_test.py
1106693 
Fixes NVIDIA#11017.

This commit fixes the tests in url_test.py, so that they don't fail
when ANSI mode is enabled.

All the errant tests fail because `parse_url()` does not currently
support "fail on error" in spark-rapids.
See NVIDIA#11193.

The tests have been modified to explicitly run with ANSI mode disabled.
These tests can be enabled to run in ANSI mode after NVIDIA#11193 has been
addressed.

Signed-off-by: MithunR <mithunr@nvidia.com>
@mythrocks mythrocks mentioned this issue Jul 15, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mythrocks mythrocks

Labels
bug Something isn't working Spark 4.0+ Spark 4.0+ issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ANSI mode test failures in url_test.py [databricks] mythrocks/spark-rapids
3 participants
@mattahrens @mythrocks @razajafri