Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix ANSI mode test failures in url_test.py [databricks] #11194

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix ANSI mode test failures in url_test.py [databricks] #11194

merged 1 commit into from
Jul 18, 2024

Conversation

mythrocks
Copy link
Collaborator

Fixes #11017.

This commit fixes the tests in url_test.py, so that they don't fail when ANSI mode is enabled.

All the errant tests fail because parse_url() does not currently support "fail on error" in spark-rapids.
See #11193.

The tests have been modified to explicitly run with ANSI mode disabled. These tests can be enabled to run in ANSI mode after #11193 has been addressed.

@mythrocks
Fix ANSI mode test failures in url_test.py
1106693 
Fixes NVIDIA#11017.

This commit fixes the tests in url_test.py, so that they don't fail
when ANSI mode is enabled.

All the errant tests fail because `parse_url()` does not currently
support "fail on error" in spark-rapids.
See NVIDIA#11193.

The tests have been modified to explicitly run with ANSI mode disabled.
These tests can be enabled to run in ANSI mode after NVIDIA#11193 has been
addressed.

Signed-off-by: MithunR <mithunr@nvidia.com>
@mythrocks mythrocks added the Spark 4.0+ Spark 4.0+ issues label Jul 15, 2024
@mythrocks mythrocks self-assigned this Jul 15, 2024
@mythrocks mythrocks changed the title Fix ANSI mode test failures in url_test.py Fix ANSI mode test failures in url_test.py [databricks] Jul 16, 2024
@mythrocks
Copy link
Collaborator Author

Build

@mythrocks
Copy link
Collaborator Author

Thank you for reviewing, @thirtiseven. Much appreciated.

@mythrocks
Copy link
Collaborator Author

Build

@mythrocks
Copy link
Collaborator Author

The CI failure seems like a transient error:

2024-07-17T19:10:10.1788614Z [2024-07-17T19:09:36.293Z] [2024-07-17T19:09:35.641Z] Also:   org.jenkinsci.plugins.workflow.steps.FlowInterruptedException
2024-07-17T19:10:10.1789613Z [2024-07-17T19:09:36.293Z] [2024-07-17T19:09:35.641Z]              at org.jenkinsci.plugins.workflow.cps.steps.ParallelStep$ResultHandler$Callback.checkAllDone(ParallelStep.java:151)
2024-07-17T19:10:10.1790583Z [2024-07-17T19:09:36.293Z] [2024-07-17T19:09:35.641Z]              at org.jenkinsci.plugins.workflow.cps.steps.ParallelStep$ResultHandler$Callback.onFailure(ParallelStep.java:138)
2024-07-17T19:10:10.1791557Z [2024-07-17T19:09:36.293Z] [2024-07-17T19:09:35.641Z]              at org.jenkinsci.plugins.workflow.cps.CpsBodyExecution$FailureAdapter.receive(CpsBodyExecution.java:356)

I'll kick things off again.

@mythrocks
Copy link
Collaborator Author

Build

@mythrocks mythrocks merged commit 7e899a0 into NVIDIA:branch-24.08 Jul 18, 2024
42 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thirtiseven thirtiseven thirtiseven approved these changes

Assignees

@mythrocks mythrocks

Labels
Spark 4.0+ Spark 4.0+ issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tests failures in url_test.py
2 participants
@mythrocks @thirtiseven