Add doc for parsing expressions in qualification tool [skip ci] #6007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
|
build |
pxLi
changed the title
|
build |
abellina
reviewed
Jul 18, 2022
docs/spark-qualification-tool.md
Outdated
| @@ -493,6 +493,53 @@ details on limitations on UDFs and unsupported operators. | |||
| 11. _Exec Children Node Ids_ | |||
| 12. _Exec Should Remove_: whether the Op is removed from the migrated plan. | |||
|
|
|||
| **Parsing Expressions within each Exec** | |||
|
|
|||
| The Qualification tool look at the expressions in the _Exec_ to extract any duration information. | |||
There was a problem hiding this comment.
Suggested change
| The Qualification tool look at the expressions in the _Exec_ to extract any duration information. | |
| The Qualification tool looks at the expressions in the _Exec_ to extract any duration information. |
abellina
reviewed
Jul 18, 2022
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
|
build |
tgravescs
reviewed
Jul 19, 2022
tgravescs
reviewed
Jul 19, 2022
tgravescs
reviewed
Jul 19, 2022
amahussein
changed the title
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
|
build |
amahussein
commented
Jul 28, 2022
tgravescs
approved these changes
Jul 28, 2022
nartal1
approved these changes
Jul 28, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
fixes #5964
We need to document the level of information extracted from each Exec.
There is an ongoing issue #5617 that adds expression's parser to the qualification tool.
Since this is an ongoing issue, I thought that adding a table of execs is the best way to document and to keep-up with the progress.
Edit