Add shim for EMR 3.0.1 and EMR 3.0.1-SNAPSHOT #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
revans2
as code owners
|
build |
tgravescs
commented
Oct 21, 2020
.../spark301emr/src/main/scala/com/nvidia/spark/rapids/shims/spark301emr/Spark301EMRShims.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
jlowe
approved these changes
Oct 21, 2020
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
* Add emr301 shim Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove snapshot from spark 3.0.1 Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Cleanupu imports and unused var Signed-off-by: Thomas Graves <tgraves@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add emr301 shim Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove snapshot from spark 3.0.1 Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Cleanupu imports and unused var Signed-off-by: Thomas Graves <tgraves@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add emr301 shim Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove snapshot from spark 3.0.1 Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Cleanupu imports and unused var Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
… to Spark (NVIDIA#995) Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new shim layer for EMR version 3.0.1 and 3.0.1-snapshot. They told us there are no differences in api between it an apache 3.0.1. The actually made the file scan RDD that was in compatible in 3.0.0 emr now compatible, so I removed that change as well. So this shim is based on the Spark301Shims one and is just a version number check.
I tested this by building apache spark with the version 3.0.1-amzn-0 and 3.0.1-amzn-0-SNAPSHOT and ran a few basic queries.
20/10/21 14:13:46 INFO ShimLoader: Loading shim for Spark version: 3.0.1-amzn-0
I have not run integration tests on this since emr 3.0.1 is not available yet but we will work with them to do so. They specifically requested support for the -SNAPSHOT for testing.
I also noticed we still had snapshot support for 3.0.1 so I removed that. If folks want I can split that apart.
fixes #905