fix(records): update records count when marking records as deleted #2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Nov 1, 2024
| @@ -263,7 +263,7 @@ export async function upsert({ | |||
| connection_id: connectionId, | |||
| model, | |||
| environment_id: environmentId, | |||
| count: Math.max(0, delta) | |||
There was a problem hiding this comment.
unrelated but max was only useful when the counts were not populated yet for historic data. removing it since it doesn't bring anything
TBonnin
commented
Nov 1, 2024
| updated_at: now, | ||
| sync_job_id: generation | ||
| }) | ||
| .returning('id')) as unknown as string[]; |
There was a problem hiding this comment.
this query hasn't changed. it is just wrapped in the transction
3 tasks
khaliqgant
approved these changes
Nov 1, 2024
TBonnin
force-pushed
the
tbonnin/nan-1929/fix-marked-as-deleted
branch
from
55136d3 to
84eb8fe
Compare
TBonnin
added a commit
that referenced
this pull request
Nov 12, 2024
Column is called `Records` cc @bastienbeurier Count is shorten when greater than 1000. Ex: 1.6K, 3M. Non-shorten count is always shown in the hover tooltip  Depends on this [bugfix](#2935) to be merged first and inaccurate rows in the db to be fixed ## Issue ticket number and link https://linear.app/nango/issue/NAN-1929/[trial]-show-object-count-in-sync-tab ## Checklist before requesting a review (skip if just adding/editing APIs & templates) - [ ] I added tests, otherwise the reason is: - [ ] I added observability, otherwise the reason is: - [ ] I added analytics, otherwise the reason is:
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
we forgot to update the records count when marking records as deleted when track_deletes = true