feat: show records count on connections page #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Nov 1, 2024
| <Table.Head className="w-[120px]">Last Sync Start</Table.Head> | ||
| <Table.Head className="w-[130px]">Next Sync Start</Table.Head> | ||
| <Table.Head className="w-[140px]">Next Sync Start</Table.Head> |
There was a problem hiding this comment.
unrelated but with 130 it would add a new line when value is Schedule Paused
TBonnin
force-pushed
the
tbonnin/nan-1929/record-count-ui
branch
2 times, most recently
from
7e65df1 to
c62465b
Compare
bodinsamuel
approved these changes
Nov 3, 2024
packages/webapp/src/utils/utils.tsx
Outdated
| } | ||
| } | ||
| return count.toLocaleString(); | ||
| } |
There was a problem hiding this comment.
You have formatQuantity() that does the same thing but shorter
TBonnin
force-pushed
the
tbonnin/nan-1929/record-count-ui
branch
from
c62465b to
14a2821
Compare
khaliqgant
approved these changes
Nov 5, 2024
bodinsamuel
approved these changes
Nov 7, 2024
TBonnin
force-pushed
the
tbonnin/nan-1929/record-count-ui
branch
from
14a2821 to
0e88f8f
Compare
|
FYI @khaliqgant @bodinsamuel added a commit to show the count breakdown per model in the tooltip |
Column is called `Records` Count is shorten when greater than 1000. Ex: 1.6K, 3M Non-shorten count is always shown in the hover tooltip
TBonnin
force-pushed
the
tbonnin/nan-1929/record-count-ui
branch
from
0e88f8f to
35c74ab
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column is called
Recordscc @bastienbeurierCount is shorten when greater than 1000. Ex: 1.6K, 3M.
Non-shorten count is always shown in the hover tooltip
Depends on this bugfix to be merged first and inaccurate rows in the db to be fixed
Issue ticket number and link
https://linear.app/nango/issue/NAN-1929/[trial]-show-object-count-in-sync-tab
Checklist before requesting a review (skip if just adding/editing APIs & templates)