Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Try to sort out the homs #1700

Merged
merged 3 commits into from
May 3, 2024
Merged

Conversation

lgoettgens
Copy link
Collaborator

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.28%. Comparing base (1f2ae64) to head (fdf0b25).

❗ Current head fdf0b25 differs from pull request most recent head 8384dd9. Consider uploading reports for the commit 8384dd9 to get more accurate results

Files Patch % Lines
src/generic/DirectSum.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1700   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files         116      116           
  Lines       29736    29736           
=======================================
+ Hits        25954    25955    +1     
+ Misses       3782     3781    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens marked this pull request as draft May 3, 2024 15:09
@lgoettgens lgoettgens closed this May 3, 2024
@lgoettgens lgoettgens reopened this May 3, 2024
@thofma
Copy link
Member

thofma commented May 3, 2024

Looks good?

@lgoettgens
Copy link
Collaborator Author

I want to wait for the last few Oscar tests.
Once green, I push version bumps to all relevant branches and would ask you to merge them (needs force due to some tests containing branch names)

@lgoettgens lgoettgens requested a review from thofma May 3, 2024 17:26
@lgoettgens lgoettgens marked this pull request as ready for review May 3, 2024 17:26
@thofma thofma merged commit b2544d9 into Nemocas:master May 3, 2024
28 of 29 checks passed
@lgoettgens lgoettgens deleted the lg/compatibility branch May 3, 2024 17:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants