[12.0][MIG] Migrated product_sequence to v12. #416

sudhir-erpharbor · 2018-12-06T13:16:24Z

Please review and give feedback.

… reference. The reference (default code) is unique (SQL constraint) and required.

… each product without default_code

some minor reformatting in the process

…e reactivated when the modules are migrated

…duct_images)

Version numbers should only have 2 digits.

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Add pre_init_hook to manually set nulls and '/' default codes to a unique code to greenify branch add pragma to pre_init method as it must have completed successfully if module installs

…ersions

* Migration to v11 * Support sequence by Product Category

oca-clabot · 2018-12-06T13:16:26Z

Hey @sudhir-erpharbor, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@SodexisTeam
Laetitia Gangloff laetitia.gangloff@acsone.eu (no github login found)
Jordi Esteve jesteve@zikzakmedia.com (no github login found)
@ <@> (no github login found)
Launchpad Translations on behalf of product-core-editors (no github login found)

Appreciation of efforts,
OCA CLAbot

atchuthan · 2018-12-07T06:31:42Z

@pedrobaeza
We have the CLA document for SodexisTeam in https://github.com/OCA/OpenUpgrade/blob/12.0/doc/cla/corporate/sodexis.md

what am I missing?

pedrobaeza · 2018-12-07T11:45:39Z

@atchuthan that one is Odoo CLA, not OCA CLA. Did you send OCA ECLA or ICLA? There's also an issue with used emails.

oca-clabot · 2018-12-12T14:21:29Z

Hey @sudhir-erpharbor, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@SodexisTeam
Laetitia Gangloff laetitia.gangloff@acsone.eu (no github login found)
Jordi Esteve jesteve@zikzakmedia.com (no github login found)
@ <@> (no github login found)
Launchpad Translations on behalf of product-core-editors (no github login found)

Appreciation of efforts,
OCA CLAbot

atchuthan · 2018-12-19T08:11:36Z

@atchuthan that one is Odoo CLA, not OCA CLA. Did you send OCA ECLA or ICLA? There's also an issue with used emails.

OCA ECLA

oca-clabot · 2019-02-25T11:31:22Z

Hey @sudhir-erpharbor, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@SodexisTeam
Jordi Esteve jesteve@zikzakmedia.com (no github login found)
Malte Jacobi malte.jacobi@htwsaar.de (no github login found)
Launchpad Translations on behalf of product-core-editors (no github login found)
@ <@> (no github login found)
Laetitia Gangloff laetitia.gangloff@acsone.eu (no github login found)

Appreciation of efforts,
OCA CLAbot

scigghia

Tested on Odoo 12 CE and works

BT-aestebanez

Thanks for your contribution.
I reviewed the code (translations not reviewed) and I only have three small comments :)
Alvaro

BT-aestebanez · 2019-07-30T07:35:14Z

product_sequence/models/product_product.py

+        she/he will need to write '/' on the internal reference to force the
+        re-assignment."""
+        for product in self:
+            if vals.get('default_code', '') == '/':


this if could be out of the loop for improving the performance

BT-aestebanez · 2019-07-30T07:35:32Z

product_sequence/models/product_product.py

+        for product in self:
+            if vals.get('default_code', '') == '/':
+                category_id = vals.get('categ_id', product.categ_id.id)
+                category = self.env['product.category'].browse(category_id)


what if there is no category?

BT-aestebanez · 2019-07-30T07:36:29Z

product_sequence/models/product_product.py

+                    sequence = self.env.ref(
+                        'product_sequence.seq_product_auto')
+                ref = sequence.next_by_id()
+                vals['default_code'] = ref


are you sure you want to update the main dict? I would say you should update only the values to write in the record of the loop

celm1990 · 2019-09-27T15:33:48Z

product_sequence/models/product_product.py

+             "to be proposed."
+    )
+
+    _sql_constraints = [


Because add sql contraints????

this functionality is added on module product_code_unique

I prefered keep into 2 modules

Yes, I agree

MiquelRForgeFlow · 2019-10-08T15:15:23Z

This PR should be closed. Superseed by #507.

Jordi Esteve and others added 30 commits December 6, 2018 18:25

[ADD] product_sequence: Allows to associate a sequence to the product…

329b9f6

… reference. The reference (default code) is unique (SQL constraint) and required.

[MERGE] merge translation commited by launchpad on extra-addons6.0

a950376

[FIX] fix write all product with default_code together and then write…

92ae2ad

… each product without default_code

[FIX] resetting sequence code when updating module

bdb8453

[REM] use Model instead of osv.osv

8e144d9

some minor reformatting in the process

[FIX] product_sequence : write should support list or integer

28c562f

[IMP] set correctly the version number 6.1.X

bb7f7f3

[MIGR] set installable to False on all the modules, the flag has to b…

7ea1f21

…e reactivated when the modules are migrated

[MIGR] migration of product_sequence to openerp 7.0 (required for pro…

5a13f95

…duct_images)

[FIX] encoding in product_sequence

0e3e278

FIX description of module product_custom_attributes.

29b9259

Version numbers should only have 2 digits.

Launchpad automatic translations update.

6bee44f

Set all addons to uninstallable and move them into __unported__ folder

f2b0d2c

MIG product_sequence

3ecdc7e

Update README.rst

1d4a745

Add OCA as author of OCA addons

ff6d6f5

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Added german translation

0da621c

Add bug tracker link on README.rst

c21ae6b

product_sequence

fa93404

Add pre_init_hook to manually set nulls and '/' default codes to a unique code to greenify branch add pragma to pre_init method as it must have completed successfully if module installs

Add missing default oca icons

4a30206

[UPD] prefix versions with 8.0

46f72fd

[MIG] Make modules uninstallable

4a3bab3

[MIG] Rename manifest files

0462969

product_sequence (OCA#156)

8e46ac7

[MIG][10.0] migrate product_sequence

38aa91d

[REM] removed demo data containing default_code propogated in older v…

4ed4b2f

…ersions

[FIX] new README.rst template & minor fixes

a4e1063

OCA Transbot updated translations from Transifex

1df4cdc

[11.0][MIG/IMP] product_sequence:

d34f198

* Migration to v11 * Support sequence by Product Category

travis

704ee0a

JordiBForgeFlow and others added 4 commits December 6, 2018 18:25

fixes and adds tests

841b3f1

remove obsolete .pot files [ci skip]

bc83cda

[UPD] Update product_sequence.pot

097a528

[MIG] Migrated product_sequence to v12

8fb2e29

OCA-git-bot mentioned this pull request Dec 7, 2018

Migration to version 12.0 #389

Closed

24 tasks

pedrobaeza added this to the 12.0 milestone Dec 7, 2018

[IMP] Improve Code.

b702422

[ADD] Added Readme.

88fdae3

scigghia approved these changes Jul 29, 2019

View reviewed changes

BT-aestebanez reviewed Jul 30, 2019

View reviewed changes

celm1990 suggested changes Sep 27, 2019

View reviewed changes

Tardo mentioned this pull request Sep 27, 2019

[12.0][MIG] product_sequence: Migration to 12.0 #507

Merged

pedrobaeza closed this Oct 8, 2019

QuocDuong1306 pushed a commit to QuocDuong1306/product-attribute that referenced this pull request Aug 9, 2023

[14.0][FIX] OCA#416

7b32908

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] Migrated product_sequence to v12. #416

[12.0][MIG] Migrated product_sequence to v12. #416

sudhir-erpharbor commented Dec 6, 2018

oca-clabot commented Dec 6, 2018

atchuthan commented Dec 7, 2018

pedrobaeza commented Dec 7, 2018

oca-clabot commented Dec 12, 2018

atchuthan commented Dec 19, 2018

oca-clabot commented Feb 25, 2019

scigghia left a comment

BT-aestebanez left a comment

BT-aestebanez Jul 30, 2019 •

edited

Loading

BT-aestebanez Jul 30, 2019

BT-aestebanez Jul 30, 2019

celm1990 Sep 27, 2019

pedrobaeza Sep 27, 2019

MiquelRForgeFlow commented Oct 8, 2019

[12.0][MIG] Migrated product_sequence to v12. #416

[12.0][MIG] Migrated product_sequence to v12. #416

Conversation

sudhir-erpharbor commented Dec 6, 2018

oca-clabot commented Dec 6, 2018

atchuthan commented Dec 7, 2018

pedrobaeza commented Dec 7, 2018

oca-clabot commented Dec 12, 2018

atchuthan commented Dec 19, 2018

oca-clabot commented Feb 25, 2019

scigghia left a comment

Choose a reason for hiding this comment

BT-aestebanez left a comment

Choose a reason for hiding this comment

BT-aestebanez Jul 30, 2019 • edited Loading

Choose a reason for hiding this comment

BT-aestebanez Jul 30, 2019

Choose a reason for hiding this comment

BT-aestebanez Jul 30, 2019

Choose a reason for hiding this comment

celm1990 Sep 27, 2019

Choose a reason for hiding this comment

pedrobaeza Sep 27, 2019

Choose a reason for hiding this comment

MiquelRForgeFlow commented Oct 8, 2019

BT-aestebanez Jul 30, 2019 •

edited

Loading