-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[12.0][MIG] product_sequence: Migration to 12.0 #507
Conversation
Hey @Tardo, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
… reference. The reference (default code) is unique (SQL constraint) and required.
… each product without default_code
some minor reformatting in the process
Version numbers should only have 2 digits.
Add pre_init_hook to manually set nulls and '/' default codes to a unique code to greenify branch add pragma to pre_init method as it must have completed successfully if module installs
* Migration to v11 * Support sequence by Product Category
3206471
to
231a83b
Compare
Hey @Tardo, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet. Appreciation of efforts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionaly 👍
Please @Tardo answer review from @Trivedi-Vacha-SerpentCS , thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor Change
231a83b
to
31c0fcd
Compare
Hey @Tardo, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet. Appreciation of efforts, |
31c0fcd
to
69a12c3
Compare
Hey @Tardo, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet. Appreciation of efforts, |
Thanks @Trivedi-Vacha-SerpentCS and @nikul-serpentcs changes done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review LGTM 👍
/ocabot merge |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 6d27692. Thanks a lot for contributing to OCA. ❤️ |
Superseded #416
@Tecnativa TT19422