Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[12.0][MIG] product_sequence: Migration to 12.0 #507

Merged
merged 24 commits into from
Oct 1, 2019

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Sep 27, 2019

Superseded #416

@Tecnativa TT19422

@oca-clabot
Copy link

Hey @Tardo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 12.0 milestone Sep 27, 2019
Jordi Esteve and others added 23 commits September 27, 2019 19:52
… reference. The reference (default code) is unique (SQL constraint) and required.
some minor reformatting in the process
Version numbers should only have 2 digits.
Add pre_init_hook to manually set nulls and '/' default codes
 to a unique code to greenify branch
add pragma to pre_init method as it must have completed successfully
if module installs
* Migration to v11
* Support sequence by Product Category
@Tardo Tardo force-pushed the 12.0-mig-product_sequence branch from 3206471 to 231a83b Compare September 27, 2019 18:12
@oca-clabot
Copy link

Hey @Tardo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionaly 👍

@rafaelbn
Copy link
Member

Please @Tardo answer review from @Trivedi-Vacha-SerpentCS , thanks!

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Change

product_sequence/data/product_sequence.xml Outdated Show resolved Hide resolved
product_sequence/views/product_category.xml Outdated Show resolved Hide resolved
@Tardo Tardo force-pushed the 12.0-mig-product_sequence branch from 231a83b to 31c0fcd Compare September 30, 2019 16:34
@oca-clabot
Copy link

Hey @Tardo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@Tardo Tardo force-pushed the 12.0-mig-product_sequence branch from 31c0fcd to 69a12c3 Compare September 30, 2019 16:37
@oca-clabot
Copy link

Hey @Tardo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@Tardo
Copy link
Member Author

Tardo commented Sep 30, 2019

Thanks @Trivedi-Vacha-SerpentCS and @nikul-serpentcs changes done.

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM 👍

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-507-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 69a12c3 into OCA:12.0 Oct 1, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6d27692. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 12.0-mig-product_sequence branch October 30, 2019 11:23
@emagdalenaC2i emagdalenaC2i mentioned this pull request Feb 19, 2020
24 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.