-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[12.0][MIGR] product_supplierinfo_for_customer #446
[12.0][MIGR] product_supplierinfo_for_customer #446
Conversation
…tomer: Complete README.
…ext key is needed in act_window Or the product template won't be shown there.
…ling The same way Odoo does.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-11.0/product-attribute-11.0-product_supplierinfo_for_customer Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_supplierinfo_for_customer/
With this module, I wanted to change a bit the implementation, doing an inheritance of Check also the red status. |
1cfef43
to
bb42340
Compare
I will push some fixes to red status for this PR. About your changes in this module, I agree, maybe we can create one object inherited from product.supplierinfo with name product.customerinfo and could we rename this module to product_customerinfo? What do you thing? I can do this :) |
I don't see the need of renaming the module, as this denotes the source of the data, but thanks for doing the refactoring. |
5505fe4
to
343b061
Compare
continue | ||
prices[product.id] = price | ||
if not uom and self._context.get('uom'): | ||
uom = self.env['product.uom'].browse(self._context['uom']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace product.uom with uom.uom, price list based on partner functional test ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renatonlima please
Dear @renatonlima could you please re-take this PR a little bit? You have comments from @youring and @mreficent and @pedrobaeza weill give last feedback, me too. Also @murtuzasaleh could review this PR and help as is interested for continuing with his PR OCA/sale-workflow#841 😄 OCA force! Let's go! |
Yes, I'm not sure if @renatonlima understood what I wanted to do. Basically it's: class ProductCustomerinfo(models.Model):
_inherit = "product.supplierinfo"
_name = "product.customerinfo"
class ProductTemplate(models.Model):
_inherit = "product.template"
customer_ids = fields.One2many(
comodel_name="product.customerinfo"
... and the rest of the needed stuff. |
Superseded in #515. |
No description provided.