Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[12.0][MIGR] product_supplierinfo_for_customer #446

Closed

Conversation

renatonlima
Copy link
Member

No description provided.

oihane and others added 30 commits April 16, 2019 18:54
@pedrobaeza pedrobaeza added this to the 12.0 milestone Apr 17, 2019
@pedrobaeza
Copy link
Member

With this module, I wanted to change a bit the implementation, doing an inheritance of product.supplierinfo, but changing the name, and thus, we avoid the hack in search method plus the modification of supplier info views. What do you think about this change? I can do it if you prefer.

Check also the red status.

@renatonlima renatonlima force-pushed the 12.0-mig-product_supplierinfo_for_customer branch from 1cfef43 to bb42340 Compare April 17, 2019 14:52
@renatonlima
Copy link
Member Author

@pedrobaeza,

I will push some fixes to red status for this PR. About your changes in this module, I agree, maybe we can create one object inherited from product.supplierinfo with name product.customerinfo and could we rename this module to product_customerinfo? What do you thing? I can do this :)

@pedrobaeza
Copy link
Member

I don't see the need of renaming the module, as this denotes the source of the data, but thanks for doing the refactoring.

@renatonlima renatonlima changed the title [12.0] product_supplierinfo_for_customer migration [12.0][MIGR] product_supplierinfo_for_customer migration Apr 17, 2019
@renatonlima renatonlima changed the title [12.0][MIGR] product_supplierinfo_for_customer migration [12.0][MIGR] product_supplierinfo_for_customer Apr 17, 2019
continue
prices[product.id] = price
if not uom and self._context.get('uom'):
uom = self.env['product.uom'].browse(self._context['uom'])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace product.uom with uom.uom, price list based on partner functional test ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renatonlima please

@emagdalenaC2i emagdalenaC2i mentioned this pull request Jun 1, 2019
24 tasks
@rafaelbn
Copy link
Member

rafaelbn commented Sep 4, 2019

Dear @renatonlima could you please re-take this PR a little bit? You have comments from @youring and @mreficent and @pedrobaeza weill give last feedback, me too.

Also @murtuzasaleh could review this PR and help as is interested for continuing with his PR OCA/sale-workflow#841 😄

OCA force! Let's go!

@pedrobaeza
Copy link
Member

Yes, I'm not sure if @renatonlima understood what I wanted to do. Basically it's:

class ProductCustomerinfo(models.Model):
    _inherit = "product.supplierinfo"
    _name = "product.customerinfo"

class ProductTemplate(models.Model):
    _inherit = "product.template"

    customer_ids = fields.One2many(
        comodel_name="product.customerinfo"
        ...

and the rest of the needed stuff.

@MiquelRForgeFlow
Copy link
Contributor

Superseded in #515.

@pedrobaeza pedrobaeza closed this Oct 24, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.