Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[12.0][MIG] product_supplierinfo_for_customer #515

Merged
merged 42 commits into from
Oct 24, 2019
Merged

[12.0][MIG] product_supplierinfo_for_customer #515

merged 42 commits into from
Oct 24, 2019

Conversation

MiquelRForgeFlow
Copy link
Contributor

Supersede of #446.

@oca-clabot
Copy link

Hey @mreficent, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-product_supplierinfo_for_customer branch 2 times, most recently from 690acd6 to 3b874d9 Compare October 15, 2019 13:23
oihane and others added 26 commits October 22, 2019 18:31
@oihane @MiquelRForgeFlow
<product_supplierinfo_for_customer>
8c481e8
@pedrobaeza @MiquelRForgeFlow
product_supplierinfo_for_customer: Views and documentation
54f5b0d
@oihane @MiquelRForgeFlow
Related to OCA#638
c5d856c
@sysadminmatmoz @MiquelRForgeFlow
Slovene translations of odoomrp modules
9bc8b21
@pedrobaeza @MiquelRForgeFlow
product_supplierinfo_for_customer: Avoid side effects + improve README
c9af9b5
@oihane @MiquelRForgeFlow
<product_supplierinfo_for_customer> Create 'customer' type from menu …
c80d658 
…option
@oihane @MiquelRForgeFlow
<product_supplierinfo_for_customer> Added know issue with computed fi…
5e106a7 
…elds
@alfredoavanzosc @MiquelRForgeFlow
product_supplierinfo_for_customer: Create "demo" data, and "tests" fo…
095decc 
…lder.
@MiquelRForgeFlow
license target link
e0dc0d2
@MiquelRForgeFlow
OCA as author added
d0297a8
@oca-transbot @MiquelRForgeFlow
OCA Transbot updated translations from Transifex
c14bfd1
@ysantiago @MiquelRForgeFlow
product_customer_code: New README. [REF] product_supplierinfo_for_cus…
6703934 
…tomer: Complete README.
@AaronHForgeFlow @MiquelRForgeFlow
product_supplierinfo_for_customer to v9
53a949d
@AaronHForgeFlow @MiquelRForgeFlow
[MIG] product_supplierinfo_for_customer to v10
afa92bd
@AaronHForgeFlow @MiquelRForgeFlow
[IMP] Add back the option to import the prices from supplierinfo to PL
bd8a8ac
@oca-travis @MiquelRForgeFlow
[UPD] Update product_supplierinfo_for_customer.pot
deee2b3
@MiquelRForgeFlow
[FIX] Move some views to product_supplierinfo_for_customer_sale
c8d682a
@oca-travis @MiquelRForgeFlow
[UPD] Update product_supplierinfo_for_customer.pot
8d03516
@MiquelRForgeFlow
[REF] Don't overwrite views and fix view for customers
3dcc6d6
@oca-travis @MiquelRForgeFlow
[UPD] Update product_supplierinfo_for_customer.pot
011f98e
@JordiBForgeFlow @MiquelRForgeFlow
fix view field names
46a6f24
@oca-travis @MiquelRForgeFlow
[UPD] Update product_supplierinfo_for_customer.pot
c45631c
@MiquelRForgeFlow
[IMP] Readem title and optimization
d20493f
@MiquelRForgeFlow
[FIX] Assure partner is passed in the context
1b8e9b9
@sergio-teruel @MiquelRForgeFlow
[11.0][MIG] product_supplier_info_for_customer: Module migration
6779a4e
@MiquelRForgeFlow
[IMP] Optimization and fixes from reviews
0c89952
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Oct 22, 2019
Closed
1 task
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-product_supplierinfo_for_customer branch from d7e83a8 to d0aebb2 Compare October 22, 2019 17:09
pedrobaeza
pedrobaeza requested changes Oct 23, 2019
View reviewed changes
product_supplierinfo_for_customer/models/product_customerinfo.py Outdated Show resolved Hide resolved
product_supplierinfo_for_customer/models/product_customerinfo.py Outdated Show resolved Hide resolved
product_supplierinfo_for_customer/models/product_template.py Outdated Show resolved Hide resolved
product_supplierinfo_for_customer/models/product_template.py Outdated Show resolved Hide resolved
product_supplierinfo_for_customer/migrations/12.0.1.0.0/post-migration.py Outdated Show resolved Hide resolved
product_supplierinfo_for_customer/migrations/12.0.1.0.0/post-migration.py Outdated Show resolved Hide resolved
product_supplierinfo_for_customer/migrations/12.0.1.0.0/post-migration.py Outdated Show resolved Hide resolved
product_supplierinfo_for_customer/migrations/12.0.1.0.0/post-migration.py Outdated Show resolved Hide resolved
product_supplierinfo_for_customer/migrations/12.0.1.0.0/post-migration.py Outdated Show resolved Hide resolved
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Oct 23, 2019
Merged
1 task
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-product_supplierinfo_for_customer branch from d0aebb2 to 70bd3df Compare October 23, 2019 14:04
@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Oct 23, 2019
Merged
1 task
pedrobaeza
pedrobaeza requested changes Oct 23, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement

CREATE TABLE ... (LIKE ... INCLUDING ALL)

is missing. Without it, no constraints are copied, so the table is half built. Please include it.

@MiquelRForgeFlow
Copy link
Contributor Author

@pedrobaeza But the table has been created before during install. The migration file is post-migration, not pre-migration.

@pedrobaeza
Copy link
Member

You must do this in pre-migration, not post

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-product_supplierinfo_for_customer branch from 70bd3df to e1aa4b9 Compare October 24, 2019 10:22
AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests with several customers and prices LGTM 👍

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Oct 24, 2019
Closed
@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-515-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 24, 2019
@OCA-git-bot
Merge PR #515 into 12.0
93977cf 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 24, 2019
Closed
24 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit e1aa4b9 into OCA:12.0 Oct 24, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bb620da. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-mig-product_supplierinfo_for_customer branch October 24, 2019 16:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.