fix: segmentation tool remains active after deletion #4648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Added SEGMENTATION_ALL_SEGMENTS_REMOVED event - Updated type definitions for segmentation methods - Fixed segmentation tool state management after segment deletion - Added proper TypeScript types for method parameters Link to Devin run: https://app.devin.ai/sessions/9720a8e6710742b29bb3649062dbb37a Co-Authored-By: Alireza Sedghi <ar.sedghi@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
❌ Deploy Preview for ohif-dev failed. Why did it fail? →
|
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Devin is currently unreachable - the session may have died. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segmentation Tool Fix
This PR addresses issue #4632 where the segmentation tool remains active after deleting all segments, preventing new segments from being added.
Changes
Testing
The changes have been tested locally and ensure that:
Link to Devin run: https://app.devin.ai/sessions/9720a8e6710742b29bb3649062dbb37a