Http2 frames 5743 v3 #11717
Closed
Http2 frames 5743 v3 #11717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 5743 Why ? To add detection capabilities
As it is not always the first frame to be created : if it is not enabled, it does not get created, and other enabled frames may be created first. see use of FrameConfigTypeIsEnabled This resulted that this other frame got its length updated on stream end, which led to false positives. Resorting on FRAME_STREAM_TYPE is more consistent. Ticket: 7213
catenacyber
requested review from
jufajardini and
victorjulien
as code owners
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11717 +/- ##
==========================================
- Coverage 82.63% 82.63% -0.01%
==========================================
Files 919 919
Lines 248925 248959 +34
==========================================
+ Hits 205703 205725 +22
- Misses 43222 43234 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on SURI_TLPR1_alerts_cmp. Pipeline 22387 |
|
Information: QA ran without warnings. Pipeline 22429 |
victorjulien
approved these changes
Sep 11, 2024
Merged
|
Merged in #11755, thanks! |
This was referenced Sep 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5743
https://redmine.openinfosecfoundation.org/issues/7213
Describe changes:
SV_BRANCH=OISF/suricata-verify#2011
#11707 with better commit message and earlier frames creation followed by set_tx