frames: fix FP because stream frame is not always the first one (backport7) #11760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ERROR: ERROR: QA failed on build_asan. Pipeline 22565 |
As it is not always the first frame to be created : if it is not enabled, it does not get created, and other enabled frames may be created first. see use of FrameConfigTypeIsEnabled This resulted that this other frame got its length updated on stream end, which led to false positives. Also checking FRAME_STREAM_TYPE is more consistent. Not a clean cherry-pick as AppLayerFrameGetLastOpenByType does not exist in main7 Ticket: 7213
catenacyber
force-pushed
the
frame-stream-7213-backport7
branch
from
8d7ac1c
to
67d6e3e
Compare
|
ERROR: ERROR: QA failed on ASAN_TLPR1_suri. Pipeline 22567 |
|
Clean in #11765 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7214
Describe changes: