-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[OUDS] Docs: Change the classes that were missing #2806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
approved these changes
Nov 29, 2024
louismaximepiton
added a commit
that referenced
this pull request
Dec 2, 2024
louismaximepiton
added a commit
that referenced
this pull request
Dec 2, 2024
1beda19
to
a5198c6
Compare
julien-deramond
approved these changes
Dec 3, 2024
…o` misplaced in the previous PRs (#2806)
a5198c6
to
23bc5a5
Compare
Renamed the commits, merging as-is. |
louismaximepiton
added a commit
that referenced
this pull request
Dec 3, 2024
…o` misplaced in the previous PRs (#2806)
nilloq
pushed a commit
that referenced
this pull request
Feb 5, 2025
Co-authored-by: Julien Déramond <julien.deramond@orange.com> Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com> chore: update tokens (#2777) Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com> Co-authored-by: Julien Déramond <julien.deramond@orange.com> chore(merge main): patched Boosted commit → be8268e (#2778) chore: update tokens (#2780) Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com> feat: add Dimension tokens, utilities and documentation (#2754) Co-authored-by: Julien Déramond <julien.deramond@orange.com> Co-authored-by: Hannah Issermann <hannah.issermann@orange.com> Co-authored-by: Vincent Prothais <vincent.prothais@orange.com> tmp changed display classname and reordering of tables and small definition Some modifs + some OUDS mods Add some OUDS mod, remove .initialism, add some documentation Thiner handle of OUDS mod + small tweaks of the doc. Adapting documentation with `px` and right values. First version with icon, missing links and the end of the icon page Remove '-web' from tokens, use mixin rather than extend, handle the icon size a bit differently and add documentation ------------ Co-authored-by: Julien Déramond <julien.deramond@orange.com> Co-authored-by: Hannah Issermann <hannah.issermann@orange.com> Co-authored-by: Vincent Prothais <vincent.prothais@orange.com> Fix ci chore: update tokens (#2790) Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com> Co-authored-by: Julien Déramond <julien.deramond@orange.com> Remove useless classes, Add font references everywhere, Add doc about the new mixin, Remove all `_config.scss` references, Add `.mw-none` utility, Update Scss tests chore: update tokens (#2793) Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com> Small tweaks of font-stack Fix CI migration guide (from v0.0.3) fix(review) ------------ Co-authored-by: Hannah Issermann <hannah.issermann@orange.com> chore: update tokens (#2794) Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com> Align with mobile apps presentation css and sass vars and maps and mixins in both guides + first version of migration guide from Boosted last fixes about bootstrap-compat migration doc fix docs job (indentation) Review migration guides and doc with LM Update site/content/docs/0.0/helpers/icon.md Remove Label font-size classes Adding examples inside the doc, and small css tweaks New ways to architect the icon + text Adding migration guides fix(ci) Start button component Add minimal, strong and negative variants Fix css-test All btn color variants fix(design): after design review Small tweak for forgotten `.text-*` and some spacings. Add color tokens in OUDS Web Align bootstrap compat buttons strictly to designed buttons Add icon buttons feat: add Typography tokens, utilities and documentation (#2774) ------------ Co-authored-by: Julien Déramond <julien.deramond@orange.com> Co-authored-by: Hannah Issermann <hannah.issermann@orange.com> Co-authored-by: Vincent Prothais <vincent.prothais@orange.com> First try for loading button Add color tokens in OUDS Web Restore all custom examples from Bootstrap Add Bootstrap basic logo for examples Rewrite all button documentation. Determinate loading, skeleton and buttons on colored background must still be implemented remove unused button-outline-variant fix(CI) fix(docs): add the forgotten `.border-*`, `.opacity-*` and a `.ms-auto` misplaced in the previous PRs (#2806) fix(docs): change the font example thumbnails (#2806) chore: update tokens (#2805) Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com> Co-authored-by: louismaxime.piton <louismaxime.piton@orange.com> chore: update tokens (#2816) --------- Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com> Co-authored-by: louismaxime.piton <louismaxime.piton@orange.com> First draft on new colors fix(ci) fix merge issues + enhance color palette Use new color tokens + add mono (on colored bg) variants Check mono tokens against bad values + implement loading button example comment mixin button-outline-variant since vars are not defined use $ouds-button-size-loader token fix css-lint continue doc and laoding/skeleton states fix btn ids start migration guides, enhance doc, bootstrap-compat fix(review) Adapt to some of the new decisions made on buttons (to be finalized), variant loader-indeterminate with span chore: update tokens (#2829) --------- Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com> Co-authored-by: louismaxime.piton <louismaxime.piton@orange.com> Add elevation color [OUDS] Add background utilities to the Colors tokens PR (#2807) change $ouds-button-space-inset-icon-alone to $ouds-button-space-inset-icon-only tokens: use new token $ouds-button-border-width-default-interaction-mono tokens: $ouds-button-color-border-default-disabled-mono well synchronized, so remove comment tokens: use new token $ouds-button-border-width-default-interaction-mono tokens: use --#{$prefix}color-opacity-transparent instead of --#{$prefix}color-opacity-invisible-black and --#{$prefix}color-content-on-status-emphasized-alt instead of --#{$prefix}color-content-on-action-negative For now, we chose to use two classes for variants on colored bg, e.g. `.btn-default.btn-on-colored-bg` Negative and colored bg Negative and colored bg Loading buttons!!! fix CI (ids) fix CI (cspell) Add border color utilities to the Colors tokens PR (#2823) Finalize loading buttons doc and example Fixes after first comments (review) Fixes after first comments (review) Fixes after first comments (review) Fixes after first comments (review) - change colored-bg with utility and add data-bs-theme + ex - change colored-bg with utility and add data-bs-theme + example with negative bg - replace old boosted btn-* by new classes in docs Replace old boosted btn-* by new classes everywhere btn-primary => btn-strong and btn-secondary and btn-outline-secondary => btn-default update tarteaucitron styles (buttons and modal size) revert examples Move Bootstrap examples into the right category after loading, put the focus back on the button Handle Bootstrap examples correctly chore(merge main): patched Boosted commit → 7bde599 (#2827) chore: update tokens (#2834) Add text color utilities to the Colors tokens PR Add color background helpers to the Colors tokens PR (#2831) changes after merge + add link to buttons guidelines First reviews from LM Proposal for new CSS Animation, closer to the previous DS one Update scss/_buttons.scss Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com> fix: several updates to take PR review comments into account fix: additional fixes on PR Buttons
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
NA
Description
Remaining tasks and questions
Questions:
Tasks:
Done list
The following was done in the PR:
To be done after the PR is merged
Motivation & Context
Types of change
Live previews