-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[OUDS] Add "Colors" tokens, utilities and documentation #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2872936
to
7f97176
Compare
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8d41cf0
to
11e7727
Compare
vprothais
reviewed
Dec 12, 2024
* Add the Bootstrap compatibilities in the doc and the code * fix(review) * fix(review)
vprothais
approved these changes
Jan 29, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
NA
Description
Remaining tasks and questions
Questions:
.bg-primary
,.bg-secondary
, etc ..._color-bg.scss
? Any better solution ? -> No better solutionTasks:
Done list
The following was done in the PR:
_color-palette.scss
._config.scss
to prepare the arrival oftokens/_semantic-colors-custom-props.scss
generated by Tokenator.--#{$prefix}focus-visible-inner-color
and--#{$prefix}focus-visible-outer-color
by--#{$prefix}color-border-focus-inset
and--#{$prefix}color-border-focus
.--#{$prefix}border-color-subtle
by--#{$prefix}color-border-emphasized
and--#{$prefix}disabled-color
by--#{$prefix}color-content-disabled
(might be changed in the future) and--#{$prefix}tertiary-active-bg
by--#{$prefix}color-action-primary-pressed
.tokens/_semantic-colors-custom-props.scss
ones.tokens/_semantic-colors-custom-props.scss
.$enable-bootstrap-compatibility
.colors.yml
,grays.yml
,palette.yml
.root
androot-inverted
.border-*
calls in the docborder(|color):
calls in the not components.text-
color occurrences in the documentation.text-bg-*
occurrences in the docsTo be done after the PR is merged
color-palette.md
should be updated once the Color theme page is developed.color-palette.md
should be updated once the Utilities colors (text) page is developed.color-palette.md
should be updated once the Utilities background (bg) page is developed.color-palette.md
should be updated once the Helpers text + background (text-bg) page is developed.color-palette.md
should be updated once the mapping to Bootstrap variable have been done.color-palette.md
should be updated once the method to generate utilities is merged.color-palette.md
should be updated once the Links are defined.color-palette.md
should be updated once the Link utilities will be developed.color-palette.md
should be updated once the Badge are defined.color-palette.md
should be updated once the Cards are defined.Motivation & Context
Types of change
Live previews