-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
automatic update of the TOC to fix page number missing issues #2556
Conversation
@jgiacomello Hi, Could you update the changelog and add some unit tests, please ? |
@Progi1984 Hi, thankyou for your feedback! Speaking of which, I noticed that with the most updated version of word (2408) the page numbers do show up, but all at 1. They only fix themselves after a manual update of the table of contents. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgiacomello Could you rebase please the PR ?
And I have added a last comment.
After that, it will be a merge.
Co-authored-by: Progi1984 <progi1984@gmail.com>
Thanks @jgiacomello for your contribution 🥳 |
Description
On several trials, I noticed that despite using
$phpWord->getSettings()->setUpdateFields(true);
, when the generated file was first opened, the chapter index only updated the page numbers and not the list as well, thus losing the references to any paragraphs (H2 and H3) in the document.On subsequent openings of the file, Word requests the updating of the table of contents fields, but requires the user to specifically select the "update entire table of contents" option, so in the case of a different choice ("update page numbers only") the references to the paragraphs present in each chapter are lost, as mentioned above.
The change made in
PhpWord/Writer/Word2007/Element/TOC.php
on line116
allows the entire table of contents to be automatically updated by only requiring the generic update of the fields, but without requiring the second step, whatever the number of file openings.Fixes #1691 #1396
Checklist:
composer run-script check --timeout=0
and no errors were reported