automatic update of the TOC to fix page number missing issues

docs/changes/2.x/2.0.0.md

@@ -5,6 +5,7 @@
 ## Enhancements
 
 - IOFactory : Added extractVariables method to extract variables from a document [@sibalonat](https://github.com/sibalonat) in [#2515](https://github.com/PHPOffice/PHPWord/pull/2515)
+- TOC : Corrected generating TOC to fix page number missing issues [@jgiacomello](https://github.com/jgiacomello) in [#2556](https://github.com/PHPOffice/PHPWord/pull/2556)
 
 ### Bug fixes
 

src/PhpWord/Writer/Word2007/Element/TOC.php

@@ -113,7 +113,7 @@ private function writeTitle(XMLWriter $xmlWriter, TOCElement $element, Title $ti
         $xmlWriter->startElement('w:r');
         $xmlWriter->startElement('w:instrText');
         $xmlWriter->writeAttribute('xml:space', 'preserve');
-        $xmlWriter->text("PAGEREF _Toc{$rId} \\h");
+        $xmlWriter->text("PAGEREF $rId \\h");
         $xmlWriter->endElement();
         $xmlWriter->endElement();
 

tests/PhpWordTests/Writer/Word2007/Element/TOCTest.php

@@ -53,4 +53,29 @@ public function testWriteTitlePageNumber(): void
         self::assertTrue($doc->elementExists('/w:document/w:body/w:p[1]/w:hyperlink/w:r[6]/w:t'));
         self::assertEquals($expectedPageNum, $doc->getElement('/w:document/w:body/w:p[1]/w:hyperlink/w:r[6]/w:t')->textContent);
     }
+
+    public function testWriteTitleWithoutpageNumber(): void
+    {
+        $phpWord = new PhpWord();
+
+        $section = $phpWord->addSection();
+        $section->addTOC();
+
+        //more than one title and random text for create more than one page
+        for ($i = 1; $i <= 10; $i++) {
+            $section->addTitle('Title ' . $i, 1);
+            $content = file_get_contents('https://loripsum.net/api/10/long');
+            \PhpOffice\PhpWord\Shared\Html::addHtml($section, $content ? $content : '', false, false);
+            $section->addPageBreak();
+        }
+
+        $doc = TestHelperDOCX::getDocument($phpWord);
+
+        for ($i = 1; $i <= 1; $i++) {
+            self::assertTrue($doc->elementExists('/w:document/w:body/w:p[' . $i . ']/w:hyperlink/w:r[1]/w:t'));
+            self::assertEquals('Title ' . $i, $doc->getElement('/w:document/w:body/w:p[' . $i . ']/w:hyperlink/w:r[1]/w:t')->textContent);
+            self::assertTrue($doc->elementExists('/w:document/w:body/w:p[' . $i . ']/w:hyperlink/w:r[4]/w:instrText'));
+            self::assertEquals('preserve', $doc->getElementAttribute('/w:document/w:body/w:p[' . $i . ']/w:hyperlink/w:r[4]/w:instrText', 'xml:space'));
+        }
+    }
 }