Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Restore functionality for mapped params with no struct name #185

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

sea-bass
Copy link
Collaborator

@sea-bass sea-bass commented Mar 20, 2024

This is... not pretty, but it seems to restore the functionality reported in #182 without breaking anything else.

@pac48 what do you think? More trouble than it's worth / should this just not be supported?

  __map_joints:
    weight: {
      type: double,
      default_value: 1.0,
      description: "map parameter without struct name",
      validation: {
        gt<>: [0.0],
      }
    }

it also supports nested!

  __map_joints:
    __map_dof_names:
      weight: {
        type: double,
        default_value: 1.0,
        description: "map parameter without struct name",
        validation: {
          gt<>: [0.0],
        }
      }

@sea-bass sea-bass requested a review from pac48 March 20, 2024 03:56
@sea-bass sea-bass self-assigned this Mar 20, 2024
Copy link
Collaborator

@pac48 pac48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this fix. I noticed CI is failing in rolling, but that seems to be unrelated.

@pac48 pac48 merged commit edfeb82 into main Mar 23, 2024
10 of 14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the maps-without-struct-name branch March 23, 2024 04:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants