Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix error with not being able to find unpack_parameter_dict when using set_params_from_dict #220

Merged
merged 1 commit into from
Oct 27, 2024
Merged

fix error with not being able to find unpack_parameter_dict when using set_params_from_dict #220

merged 1 commit into from
Oct 27, 2024

Conversation

Glonks
Copy link
Contributor

@Glonks Glonks commented Sep 19, 2024

This closes #219

@Glonks Glonks changed the title fixed error with not being able to find unpack_parameter_dict when using set_params_from_dict fix error with not being able to find unpack_parameter_dict when using set_params_from_dict Sep 19, 2024
sea-bass
sea-bass approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess another alternative to removing the @staticmethod is to change the calls to ParamListener.unpack_parameter_dict(...). But this is good for me.

@sea-bass sea-bass mentioned this pull request Oct 27, 2024
Merged
@JafarAbdi JafarAbdi merged commit 6ba8e67 into PickNikRobotics:main Oct 27, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JafarAbdi JafarAbdi JafarAbdi approved these changes

@sea-bass sea-bass sea-bass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of set_params_from_dict fails
3 participants
@Glonks @sea-bass @JafarAbdi