Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use unique artifact name to upload logs on CI failure #230

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

sea-bass
Copy link
Collaborator

@sea-bass sea-bass commented Jan 6, 2025

There is an issue when CI fails, in that both the test and log results artifacts uploaded on failure had the same name!

Run actions/upload-artifact@v4
With the provided path, there will be [12](https://github.com/PickNikRobotics/generate_parameter_library/actions/runs/12634499926/job/35202363937#step:5:13)2 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

@sea-bass
Copy link
Collaborator Author

sea-bass commented Jan 6, 2025

Hah, apparently the upload-artifact v4 has this problem: actions/upload-artifact#478

I'm rolling it back
Apparently there is an overwrite parameter

@sea-bass sea-bass merged commit 3b17494 into main Jan 6, 2025
7 checks passed
@sea-bass sea-bass deleted the artifact-name-deconflict branch January 6, 2025 15:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants