Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update accessing mapped parameters in README #234

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

pawelir
Copy link
Contributor

@pawelir pawelir commented Jan 9, 2025

Currently an example of accessing mapped parameters is misleading. This PR aims to propose an update showcasing the exact syntax.

Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the .at() is the way to access them in C++, we use that in ros2_controllers

.get_entry() is for python, so we should add both

@pawelir
Copy link
Contributor Author

pawelir commented Jan 10, 2025

Sure @christophfroehlich, please find updated version

Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sea-bass sea-bass merged commit 6d88bc2 into PickNikRobotics:main Jan 10, 2025
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants