Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add position scale parameter #47

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

SammyRamone
Copy link
Contributor

Solves #45

src/goal.cpp Outdated Show resolved Hide resolved
tests/goal_tests.cpp Show resolved Hide resolved
@SammyRamone
Copy link
Contributor Author

I added commits with your suggestions.
Sorry, for the extra formatting commit again. Somehow my IDE is acting up 🤷‍♂️

Copy link
Collaborator

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for tackling this!

One comment about using const& in the new functions, and then a bunch of minor consistency things.

src/goal.cpp Outdated Show resolved Hide resolved
doc/USAGE.md Outdated Show resolved Hide resolved
src/goal.cpp Outdated Show resolved Hide resolved
tests/goal_tests.cpp Show resolved Hide resolved
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants