Fix gripper speed and force parameter initialization and scaling #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
approved these changes
Mar 4, 2025
pac48
previously approved these changes
Mar 4, 2025
JafarAbdi
force-pushed
the
fix_speed_force_logics
branch
from
f4fcaf5 to
8773042
Compare
Co-authored-by: Ashwin Varghese Kuruttukulam <ashwinvk@nvidia.com>
JafarAbdi
force-pushed
the
fix_speed_force_logics
branch
from
c06df28 to
b047cfa
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the gripper speed and force initialization logic. The previous implementation incorrectly used the .count() method instead of retrieving the actual parameter values. Additionally, this PR improves the code in the write()
method by introducing clearer variable names for the speed and force multipliers.
Fix: #57