Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Autodesk: Adopt size_t and add checks to fix image loading/processing crash #3119

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Autodesk: Adopt size_t and add checks to fix image loading/processing crash #3119

merged 1 commit into from
Jun 28, 2024

Conversation

erikaharrison-adsk
Copy link
Contributor

Description of Change(s)

  • Use size_t instead of int to fix crash caused by int overflow.
  • Add more checks as IO may fail due to users' environment.

Fixes Issue(s)

  • N/A
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-9753

@jesschimein
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pixar-oss pixar-oss merged commit 2b3bf68 into PixarAnimationStudios:dev Jun 28, 2024
3 of 5 checks passed
@erikaharrison-adsk erikaharrison-adsk mentioned this pull request Oct 2, 2024
Open
2 tasks
@erikaharrison-adsk erikaharrison-adsk deleted the adsk/bugfix/oiio-crash-fix branch October 5, 2024 01:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikaharrison-adsk @jesschimein @pixar-oss @adskWangl