-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
rm -rf /opt/hostedtoolcache
may change the python version actually used to run CI tests
#7416
Labels
bug
Something isn't working
Comments
KumoLiu
added a commit
to KumoLiu/MONAI
that referenced
this issue
Jan 30, 2024
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
7 tasks
KumoLiu
added a commit
that referenced
this issue
Feb 1, 2024
…7424) Fixes #7416 ### Description update `rm -rf /opt/hostedtoolcache` avoid change the python version ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
juampatronics
pushed a commit
to juampatronics/MONAI
that referenced
this issue
Mar 25, 2024
…roject-MONAI#7424) Fixes Project-MONAI#7416 ### Description update `rm -rf /opt/hostedtoolcache` avoid change the python version ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610
pushed a commit
to Yu0610/MONAI
that referenced
this issue
Apr 11, 2024
…roject-MONAI#7424) Fixes Project-MONAI#7416 ### Description update `rm -rf /opt/hostedtoolcache` avoid change the python version ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Describe the bug
When I run some tests on github action in model zoo repo, I found that the following line in the action yml file will remove the installed python version:
It may lead to the system's default python version will be used to run the tests.
@KumoLiu and I simply check MONAI repo, and found that at least the
deploy
action is impacted. In the corresponding yml file:MONAI/.github/workflows/setupapp.yml
Line 103 in 6c9e49e
rm -rf /opt/hostedtoolcache
is used after python env is set.If we look at the latest deploy action job, we can see that the python3.9 test actually uses python 3.10 which is not expected.
https://github.com/Project-MONAI/MONAI/actions/runs/7648726812/job/20842001933#step:7:411
Hi @wyli @KumoLiu , I think we should think about how to install the expected python version back before running tests if need
rm -rf /opt/hostedtoolcache
The text was updated successfully, but these errors were encountered: